Update code & fix typos.

Author: bradp

wp-admin/admin-footer.php

@@ -63,7 +63,7 @@
 </div>
 <?php
 /**
- * Print scripts or data before the default footer scripts.
+ * Prints scripts or data before the default footer scripts.
  *
  * @since 1.2.0
  *
@@ -92,7 +92,7 @@
 do_action( 'admin_print_footer_scripts' );
 
 /**
- * Print scripts or data after the default footer scripts.
+ * Prints scripts or data after the default footer scripts.
  *
  * The dynamic portion of the hook name, `$hook_suffix`,
  * refers to the global hook suffix of the current page.

wp-admin/admin-header.php

@@ -229,29 +229,29 @@
 
 if ( is_network_admin() ) {
 	/**
-	 * Print network admin screen notices.
+	 * Prints network admin screen notices.
 	 *
 	 * @since 3.1.0
 	 */
 	do_action( 'network_admin_notices' );
 } elseif ( is_user_admin() ) {
 	/**
-	 * Print user admin screen notices.
+	 * Prints user admin screen notices.
 	 *
 	 * @since 3.1.0
 	 */
 	do_action( 'user_admin_notices' );
 } else {
 	/**
-	 * Print admin screen notices.
+	 * Prints admin screen notices.
 	 *
 	 * @since 3.1.0
 	 */
 	do_action( 'admin_notices' );
 }
 
 /**
- * Print generic admin screen notices.
+ * Prints generic admin screen notices.
  *
  * @since 3.1.0
  */

wp-admin/css/customize-controls-rtl.css

@@ -636,7 +636,9 @@ p.customize-section-description {
 
 #customize-controls .customize-control-widget_form.has-error .widget .widget-top,
 .customize-control-nav_menu_item.has-error .menu-item-bar .menu-item-handle {
+	-webkit-box-shadow: inset 0 0 0 2px #dc3232;
 	box-shadow: inset 0 0 0 2px #dc3232;
+	-webkit-transition: .15s box-shadow linear;
 	transition: .15s box-shadow linear;
 }
 

wp-admin/css/customize-controls-rtl.min.css

@@ -636,7 +636,9 @@ p.customize-section-description {
 
 #customize-controls .customize-control-widget_form.has-error .widget .widget-top,
 .customize-control-nav_menu_item.has-error .menu-item-bar .menu-item-handle {
+	-webkit-box-shadow: inset 0 0 0 2px #dc3232;
 	box-shadow: inset 0 0 0 2px #dc3232;
+	-webkit-transition: .15s box-shadow linear;
 	transition: .15s box-shadow linear;
 }
 

wp-admin/css/customize-controls.css

@@ -377,16 +377,6 @@ form#tags-filter {
 	position: relative;
 }
 
-#content-textarea-clone {
-	z-index: -1;
-	position: absolute;
-	top: 0;
-	visibility: hidden;
-	overflow: hidden;
-	max-width: 100%;
-	border: 1px solid transparent;
-}
-
 .wp-editor-expand #wp-content-editor-tools {
 	z-index: 1000;
 	border-bottom: 1px solid #e5e5e5;
@@ -644,19 +634,6 @@ span.wp-media-buttons-icon:before {
 	max-width: 100%;
 }
 
-#poststuff .inside label.spam,
-#poststuff .inside label.deleted {
-	color: red;
-}
-
-#poststuff .inside label.waiting {
-	color: orange;
-}
-
-#poststuff .inside label.approved {
-	color: green;
-}
-
 .ie8 #poststuff .inside #parent_id,
 .ie8 #poststuff .inside #page_template {
 	width: 250px;
@@ -1139,6 +1116,7 @@ p.popular-tags a {
 	padding: 0 4px;
 	color: #72777C;
 	font-size: 13px;
+	word-break: break-all;
 }
 
 .comment-ays .comment-content p.edit-comment {

wp-admin/css/customize-controls.min.css

@@ -377,16 +377,6 @@ form#tags-filter {
 	position: relative;
 }
 
-#content-textarea-clone {
-	z-index: -1;
-	position: absolute;
-	top: 0;
-	visibility: hidden;
-	overflow: hidden;
-	max-width: 100%;
-	border: 1px solid transparent;
-}
-
 .wp-editor-expand #wp-content-editor-tools {
 	z-index: 1000;
 	border-bottom: 1px solid #e5e5e5;
@@ -644,19 +634,6 @@ span.wp-media-buttons-icon:before {
 	max-width: 100%;
 }
 
-#poststuff .inside label.spam,
-#poststuff .inside label.deleted {
-	color: red;
-}
-
-#poststuff .inside label.waiting {
-	color: orange;
-}
-
-#poststuff .inside label.approved {
-	color: green;
-}
-
 .ie8 #poststuff .inside #parent_id,
 .ie8 #poststuff .inside #page_template {
 	width: 250px;
@@ -1139,6 +1116,7 @@ p.popular-tags a {
 	padding: 0 4px;
 	color: #72777C;
 	font-size: 13px;
+	word-break: break-all;
 }
 
 .comment-ays .comment-content p.edit-comment {

wp-admin/css/edit-rtl.css

@@ -178,7 +178,7 @@
 	<?php
 
 	/**
-	 * Print templates, control scripts, and settings in the footer.
+	 * Prints templates, control scripts, and settings in the footer.
 	 *
 	 * @since 3.4.0
 	 */

wp-admin/css/edit-rtl.min.css

@@ -82,9 +82,9 @@
 
 <fieldset class="misc-pub-section misc-pub-comment-status" id="comment-status-radio">
 <legend class="screen-reader-text"><?php _e( 'Comment status' ); ?></legend>
-<label class="approved"><input type="radio"<?php checked( $comment->comment_approved, '1' ); ?> name="comment_status" value="1" /><?php _ex( 'Approved', 'comment status' ); ?></label><br />
-<label class="waiting"><input type="radio"<?php checked( $comment->comment_approved, '0' ); ?> name="comment_status" value="0" /><?php _ex( 'Pending', 'comment status' ); ?></label><br />
-<label class="spam"><input type="radio"<?php checked( $comment->comment_approved, 'spam' ); ?> name="comment_status" value="spam" /><?php _ex( 'Spam', 'comment status' ); ?></label>
+<label><input type="radio"<?php checked( $comment->comment_approved, '1' ); ?> name="comment_status" value="1" /><?php _ex( 'Approved', 'comment status' ); ?></label><br />
+<label><input type="radio"<?php checked( $comment->comment_approved, '0' ); ?> name="comment_status" value="0" /><?php _ex( 'Pending', 'comment status' ); ?></label><br />
+<label><input type="radio"<?php checked( $comment->comment_approved, 'spam' ); ?> name="comment_status" value="spam" /><?php _ex( 'Spam', 'comment status' ); ?></label>
 </fieldset>
 
 <div class="misc-pub-section curtime misc-pub-curtime">

wp-admin/css/edit.css

@@ -43,7 +43,8 @@
 add_action( 'admin_head', 'wp_site_icon'             );
 add_action( 'admin_head', '_ipad_meta'               );
 
-add_action( 'post_edit_form_tag', 'post_form_autocomplete_off' );
+add_action( 'admin_print_scripts-post.php',     'wp_page_reload_on_back_button_js' );
+add_action( 'admin_print_scripts-post-new.php', 'wp_page_reload_on_back_button_js' );
 
 add_action( 'update_option_home',          'update_home_siteurl', 10, 2 );
 add_action( 'update_option_siteurl',       'update_home_siteurl', 10, 2 );
@@ -109,3 +110,6 @@
 
 // Upgrade hooks.
 add_action( 'upgrader_process_complete', array( 'Language_Pack_Upgrader', 'async_upgrade' ), 20 );
+add_action( 'upgrader_process_complete', 'wp_version_check', 10, 0 );
+add_action( 'upgrader_process_complete', 'wp_update_plugins', 10, 0 );
+add_action( 'upgrader_process_complete', 'wp_update_themes', 10, 0 );

wp-admin/css/edit.min.css

@@ -951,7 +951,7 @@ function wp_ajax_get_comments( $action ) {
 	$x = new WP_Ajax_Response();
 	ob_start();
 	foreach ( $wp_list_table->items as $comment ) {
-		if ( ! current_user_can( 'edit_comment', $comment->comment_ID ) )
+		if ( ! current_user_can( 'edit_comment', $comment->comment_ID ) && 0 === $comment->comment_approved )
 			continue;
 		get_comment( $comment );
 		$wp_list_table->single_row( $comment );

wp-admin/customize.php

@@ -201,8 +201,7 @@ protected function get_views() {
 
 		$status_links = array();
 		$num_comments = ( $post_id ) ? wp_count_comments( $post_id ) : wp_count_comments();
-		//, number_format_i18n($num_comments->moderated) ), "<span class='comment-count'>" . number_format_i18n($num_comments->moderated) . "</span>"),
-		//, number_format_i18n($num_comments->spam) ), "<span class='spam-comment-count'>" . number_format_i18n($num_comments->spam) . "</span>")
+
 		$stati = array(
 			/* translators: %s: all comments count */
 			'all' => _nx_noop(

wp-admin/edit-form-comment.php

@@ -651,6 +651,8 @@ public function run( $options ) {
 		/**
 		 * Filters the package options before running an update.
 		 *
+		 * See also {@see 'upgrader_process_complete'}.
+		 *
 		 * @since 4.3.0
 		 *
 		 * @param array $options {
@@ -662,7 +664,18 @@ public function run( $options ) {
 		 *     @type bool   $clear_working               Clear the working resource.
 		 *     @type bool   $abort_if_destination_exists Abort if the Destination directory exists.
 		 *     @type bool   $is_multi                    Whether the upgrader is running multiple times.
-		 *     @type array  $hook_extra                  Extra hook arguments.
+		 *     @type array  $hook_extra {
+		 *         Extra hook arguments.
+		 *
+		 *         @type string $action               Type of action. Default 'update'.
+		 *         @type string $type                 Type of update process. Accepts 'plugin', 'theme', or 'core'.
+		 *         @type bool   $bulk                 Whether the update process is a bulk update. Default true.
+		 *         @type string $plugin               The base plugin path from the plugins directory.
+		 *         @type string $theme                The stylesheet or template name of the theme.
+		 *         @type string $language_update_type The language pack update type. Accepts 'plugin', 'theme',
+		 *                                            or 'core'.
+		 *         @type object $language_update      The language pack update offer.
+		 *     }
 		 * }
 		 */
 		$options = apply_filters( 'upgrader_package_options', $options );
@@ -745,6 +758,8 @@ public function run( $options ) {
 			/**
 			 * Fires when the upgrader process is complete.
 			 *
+			 * See also {@see 'upgrader_package_options'}.
+			 *
 			 * @since 3.6.0
 			 * @since 3.7.0 Added to WP_Upgrader::run().
 			 *
@@ -753,14 +768,11 @@ public function run( $options ) {
 			 * @param array       $hook_extra {
 			 *     Array of bulk item update data.
 			 *
-			 *     @type string $action               Type of action. Default 'update'.
-			 *     @type string $type                 Type of update process. Accepts 'plugin', 'theme', or 'core'.
-			 *     @type bool   $bulk                 Whether the update process is a bulk update. Default true.
-			 *     @type string $plugin               The base plugin path from the plugins directory.
-			 *     @type string $theme                The stylesheet or template name of the theme.
-			 *     @type string $language_update_type The language pack update type. Accepts 'plugin', 'theme',
-			 *                                        or 'core'.
-			 *     @type object $language_update      The language pack update offer.
+			 *     @type string $action  Type of action. Default 'update'.
+			 *     @type string $type    Type of update process. Accepts 'plugin', 'theme', or 'core'.
+			 *     @type bool   $bulk    Whether the update process is a bulk update. Default true.
+			 *     @type array  $plugins Array of the basename paths of the plugins' main files.
+			 *     @type array  $themes  The theme slugs.
 			 * }
 			 */
 			do_action( 'upgrader_process_complete', $this, $options['hook_extra'] );

wp-admin/includes/admin-filters.php

@@ -1373,3 +1373,26 @@ function add_utility_page( $page_title, $menu_title, $capability, $menu_slug, $f
 
 	return add_menu_page($page_title, $menu_title, $capability, $menu_slug, $function, $icon_url, $_wp_last_utility_menu);
 }
+
+/**
+ * Disables autocomplete on the 'post' form (Add/Edit Post screens) for WebKit browsers,
+ * as they disregard the autocomplete setting on the editor textarea. That can break the editor
+ * when the user navigates to it with the browser's Back button. See #28037
+ *
+ * Replaced with wp_page_reload_on_back_button_js() that also fixes this problem.
+ *
+ * @since 4.0.0
+ * $deprecated 4.6.0
+ *
+ * @global bool $is_safari
+ * @global bool $is_chrome
+ */
+function post_form_autocomplete_off() {
+	global $is_safari, $is_chrome;
+
+	_deprecated_function( __FUNCTION__, '4.6' );
+
+	if ( $is_safari || $is_chrome ) {
+		echo ' autocomplete="off"';
+	}
+}

wp-admin/includes/ajax-actions.php

@@ -493,7 +493,9 @@ function download_url( $url, $timeout = 300 ) {
 	if ( ! $url )
 		return new WP_Error('http_no_url', __('Invalid URL Provided.'));
 
-	$tmpfname = wp_tempnam($url);
+	$url_filename = basename( parse_url( $url, PHP_URL_PATH ) );
+
+	$tmpfname = wp_tempnam( $url_filename );
 	if ( ! $tmpfname )
 		return new WP_Error('http_no_file', __('Could not create Temporary file.'));
 

wp-admin/includes/class-wp-comments-list-table.php

@@ -891,24 +891,6 @@ function heartbeat_autosave( $response, $data ) {
 	return $response;
 }
 
-/**
- * Disables autocomplete on the 'post' form (Add/Edit Post screens) for WebKit browsers,
- * as they disregard the autocomplete setting on the editor textarea. That can break the editor
- * when the user navigates to it with the browser's Back button. See #28037
- *
- * @since 4.0.0
- *
- * @global bool $is_safari
- * @global bool $is_chrome
- */
-function post_form_autocomplete_off() {
-	global $is_safari, $is_chrome;
-
-	if ( $is_safari || $is_chrome ) {
-		echo ' autocomplete="off"';
-	}
-}
-
 /**
  * Remove single-use URL parameters and create canonical link based on new URL.
  *
@@ -936,3 +918,21 @@ function wp_admin_canonical_url() {
 	</script>
 <?php
 }
+
+/**
+ * Output JS that reloads the page if the user navigated to it with the Back or Forward button.
+ *
+ * Used on the Edit Post and Add New Post screens. Needed to ensure the page is not loaded from browser cache,
+ * so the post title and editor content are the last saved versions. Ideally this script should run first in the head.
+ *
+ * @since 4.6.0
+ */
+function wp_page_reload_on_back_button_js() {
+	?>
+	<script>
+		if ( typeof performance !== 'undefined' && performance.navigation && performance.navigation.type === 2 ) {
+			document.location.reload( true );
+		}
+	</script>
+	<?php
+}