Fetish of Volatile Power doesn't apply stacks as in game.

[ClayProof]

Describe the bug
Fetish of Volatile Power does not gain it's stacks correctly as it triggers of spell hit not casts in game.

To Reproduce

As shows here it is currently only applying stacks on casts, In this case at each Starfire.

Expected behavior
An easy way to verify the actual behavior in game is with Starfall as every star's damage as well as the splash seem to count as a separate instance, so the trinket usually gets to the full 8 stacks a lot faster (2 per star hit with the normal damage and the splash). It does not seem to apply with dot ticks.

[lime-green]

@ClayProof looking at some logs the proc is very strange, proccing 3 times off 1 starfire:

and yea, proccing twice from a single starfall:

@ClayProof do you have any idea why it would be proccing three times on a starfire? I'm not very familiar with boomkins but it looks like this trinket should be proccing a lot more than it is currently

[lime-green]

OK I figured it out, it can can proc 3 times on starfire: once from starfire itself, once from the re-application of moonfire via the glpyh and once from the application of earth and moon

[ClayProof]

I think that is correct. Not the biggest deal as the trinket is behind in power level. But for folks catching up seeing the correct Sim values might matter. Den lör 9 sep. 2023 06:45Josh ***@***.***> skrev:

…

OK I figured it out, it can can proc 3 times on starfire: once from starfire itself, once from the re-application of moonfire via the glpyh and once from the application of earth and moon — Reply to this email directly, view it on GitHub <#3362 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BBOTB5G2GYIOPJLRZGX37YDXZPX7HANCNFSM6AAAAAA2URCER4> . You are receiving this because you were mentioned.Message ID: ***@***.***>