Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Death and Decay to pre-pull timer adds damage #4007

Closed
Shaklor opened this issue Nov 5, 2023 · 0 comments · Fixed by #4016
Closed

Adding Death and Decay to pre-pull timer adds damage #4007

Shaklor opened this issue Nov 5, 2023 · 0 comments · Fixed by #4016

Comments

@Shaklor
Copy link
Contributor

Shaklor commented Nov 5, 2023

Describe the bug
In the Death Knight sim, if you set Death and Decay to cast in pre-pull - it will add damage to the result.
DKs cast D&D onto blank areas in pre-pull to generate runic power and to proc 4piece T10, and this is something we would like to be able to simulate without skewing the results with damage that wont actually be included in the encounter..

To Reproduce
Steps to reproduce the behavior:

  1. Go to the Death Knight sim and select Blood or Frost talents (as they do not cast D&D normally)
  2. Set any APL and add a Death and Decay cast to -30 seconds
  3. Simulate and go to Results -> Damage
  4. At the bottom you will see D&D damage done

Expected behavior
Expect that if a damaging ability is cast during pre-pull it does not count towards Simmed damage.

Sim Links and Screenshots
https://wowsims.github.io/wotlk/deathknight/#eJztVm1sFEUYvpm5u+6+tnY7vZbtpC3Hqk2z5nRvlyMthNxBNLWSmIoxVKIx/ECMabChP5SamLZaEMSUGiJQ/KGAplaDSKJCJYYUE1ND0ya2NBh/iEVtbZTmCLHi58x+9LbtVSCgv5wfd7PP+7wf837MLmgSVrCBn0SNqAWhboSOInQKoSGExhGaRngI49UlUWygFKp3OC8h9IbDxIgG2FuFbShc17Bh68YtkqwAu4AgX5naTdSJMi380Wn8Tj8GWeneRTTy4QkMuUqay74p04gQ5ConL2H1lzJHlq/8zGXTXI/LBJCnjL1M1PZyLcifAvzxIpfvKXUfqXKSSztLNXnwhKALDapM7CHqxTJNPvuXAAZts4Oc91qpFnZ4PJyvu9xwZKXdiyyofLKD8N/xtIjrg11E7WFezOKpm3m8jl6s5UnYCNYF64PPioQcxJcxnMKB/9cNLWpcr0ZzjoRUzPvxCopCgJXKDrw0VeBsppIqiiIdK6gK7UQVpmUkDMNIxCyT/1oJw0qYpmEZcS4wDMuKG3ErEf8WqdKBYazsHcbqT9/h6L5hXLlvBBv7R/A4Ck6hnC4U6MOv56kEIiCxMASlV7cRTQK+i1lG0wy6/VfsonGrCYpdtJV3HADHY/H4XYkMe0eGzW0UumjXANZyIAQkVtUERS64t49oMnA4ZgoLhT7LDjfeBAUQZkHAasEMRIMMLw/QxawMCvR8KUjx/QFmC7lDxl1L5ztJFNE1rBZW0hWg6Le6JG4cMPdPdUVCNPQjwlKQcT1AJhTqBZwV6iFYwg7R9BsrZ6VzDSUc+YX3hbyUsSxycZovO0k2bcvR3rlNaMfYnbCELYZ8PY8Hxk/nRGVArkixKcx8fITY5n4bIJQx1Sd5m0uEqVbb1Chiw8hLzHIvMdVN5qfITe+5MezuPt9N3N3373q7N7djgMzB3b19SK+Ur3jcoUsLc+fjzt7RnJ7EWdj/qElNZkAFvR1UvZifTXrKy4rdbHYLzs4Uj5NuZc/A4/QxKNEXcR25B7nH9imF0rwNkPOHIXTFfirSCzPdkOHKogkFg2S2QTMyLzHcA9VYFFRaDPIxzynIB5GbYqelaREr9Mm9/GeDeYHoelYPS6k5J2LXqKiqz5V7DvsPm9EsJci0gUhUG5IQex5qaY3fikh1mMq9M6F4Y5ZJNRTrkVnlsLt7WZMZn5cV4TF/Sx7c0oWyV3gFq4a7acyL4L0BMsdPeK4fKzNjm9hGeISu85R7O4g308cyM80vFB9IZsCru8mMehVbBjqttG+RsHOLYGde436MuJjvfFFW7jLIF8gbzXjCZ7uOPQD30NULJdUXp1vgRXqRqFCPv1kEc6awFovDHfQ2n6ZQCflsz7o6nfvI14C8CDMp5rXyppfmMt/M0nXsYVij1UINu9eeHUJDbZjH58yOIWbHB+PsMMnA3uvhKxTowoFz7idJRUo7QNx342bv3RhJlXTtF6s/We0gQ8klT9jrbNKcxI0/tODmnFUNmzY0PL05+pAq6f/yF85Ua+pmmGnp/+xG7BwdTL+w6mbEkW3ZiW45k065HqaS94nvx7X25+Ppy5WPdvTJqdFDjSthdCx5rUadKk4kHf2RBfSmksfL2ycfPP5ncq29GU86en8kDwt3h8aTkSM155sj6QX9PmcTXrzmuP7rRY2BM2JJKedEv1810vXX/cH5N6igx7Y=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant