3.19 - Preload Fonts - Beacon insertion part

[piotrbak]

User Story
As a user, I’d like beacon to collect data when there’s no entry in the db

Acceptance Criteria

• When visiting the uncached page while no data in DB, the same beacon script is added to process the preload fonts (no regression for beacon script injection)

[jeawhanlee]

Most of the part that handles this have already been introduced in 3.16 . We can find that module here We just need to declare the factory to be loaded there.

Scope a solution ✅

• Create a Frontend Controller Class if not created: WP_Rocket\Engine\Media\PreloadFonts\Frontend\Controller to implement WP_Rocket\Engine\Common\PerformanceHints\Frontend\ControllerInterface;
• Create 2 mandatory methods if not created ( optimize & add_custom_data ), to match the interface here and will focus on add_custom_data method that will hold custom data to be passed to the beacon during insertion, in this case system fonts which will filterable.
• Create a Factory for PreloadFonts like the way we do here for ATF if not created
• Create the queries method (product) required for this task if not created and make sure it extends WP_Rocket\Engine\Common\PerformanceHints\Database\Queries\AbstractQueries and implements ``WP_Rocket\Engine\Common\PerformanceHints\Database\Queries\QueriesInterface
• Update service providers if not already having the factory

Estimate the effort ✅

[S]

[Miraeld]

@wp-media/engineering-plugin-team I've created a PR related to this issue, however, as the branch feature/preload-fonts is missing the Database part of the new feature, I can't make it runnable. However, I've added abstract references in the ServiceProvider so references are there, but will need to modify later on.

wp-rocket/inc/Engine/Media/PreloadFonts/ServiceProvider.php

Lines 8 to 9 in 5e7d40c

	use WP_Rocket\Engine\Common\PerformanceHints\Database\Table\AbstractTable as Table;
	use WP_Rocket\Engine\Common\PerformanceHints\Database\Queries\AbstractQueries as Queries;

I'm wondering tho how would be the best way to handle this scenario... Should I base my own branch on #7242 even tho it's not validated yet ?

[Khadreal]

I think you can base your branch off #7242 so you can validate what you've done properly

[Miraeld]

I was waiting your to get reviewed before doing this, to avoid changes in case there were some. But sure I'll do.

[wordpressfan]

That's merged already