Skip to content

Commit 852e91d

Browse files
authored
fix: build windows parallel with ifort 2021.12 (MODFLOW-ORG#1853)
The Windows parallel distribution was built with Intel Fortran Classic 2021.11.1 until now. When running PRT models, Win parallel distributions built with this version of the compiler produce a runtime error in MethodSubcellPool.f90 when the method pool's pointers to tracking methods are deallocated. This seems like a compiler bug, though we also do not properly deallocate all pointers on the method types, which could cause memory leaks if in future PRT is modified such that allocation/deallocation happens multiple times. This will be fixed in a subsequent PR. The crash only occurs on the Windows parallel distribution because we use ifort 2021.7 to build the other Intel distributions. The reason we did not use 2021.7 to build the Win parallel dist is parallel requires the oneAPI base kit, and I've been unable to find the installer URL for that base kit. Luckily the latest ifort (2021.12.0) doesn't have the same issue, so we can simply switch the Win parallel dist to 2021.12.0.
1 parent aa6ef28 commit 852e91d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/actions/setup-par-oneapi/action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ runs:
2424
shell: bash
2525
if: steps.oneapi-cache.outputs.cache-hit != 'true'
2626
run: |
27-
url="https://registrationcenter-download.intel.com/akdlm/IRC_NAS/5cb30fb9-21e9-47e8-82da-a91e00191670/w_BaseKit_p_2024.0.1.45_offline.exe"
27+
url="https://registrationcenter-download.intel.com/akdlm/IRC_NAS/7dff44ba-e3af-4448-841c-0d616c8da6e7/w_BaseKit_p_2024.1.0.595_offline.exe"
2828
cmp="intel.oneapi.win.mkl.devel"
2929
"$GITHUB_WORKSPACE/modflow6/.github/common/install_intel_windows.bat" $url $cmp
3030
rm -rf $TEMP/webimage.exe
@@ -34,7 +34,7 @@ runs:
3434
shell: bash
3535
if: steps.oneapi-cache.outputs.cache-hit != 'true'
3636
run: |
37-
url="https://registrationcenter-download.intel.com/akdlm/IRC_NAS/7a6db8a1-a8b9-4043-8e8e-ca54b56c34e4/w_HPCKit_p_2024.0.1.35_offline.exe"
37+
url="https://registrationcenter-download.intel.com/akdlm/IRC_NAS/c95a3b26-fc45-496c-833b-df08b10297b9/w_HPCKit_p_2024.1.0.561_offline.exe"
3838
cmp="intel.oneapi.win.cpp-dpcpp-common:intel.oneapi.win.ifort-compiler:intel.oneapi.win.mpi.devel"
3939
"$GITHUB_WORKSPACE/modflow6/.github/common/install_intel_windows.bat" $url $cmp
4040
rm -rf $TEMP/webimage.exe

0 commit comments

Comments
 (0)