Skip to content

Commit a1af64c

Browse files
authored
ci: add jobs to build/test with gfortran in debug mode (MODFLOW-ORG#1966)
Add jobs to the gfortran test matrix in ci.yml to build and test in debug mode. The intent is to catch situations like the one fixed by MODFLOW-ORG#1959. To avoid too much CI burden this PR only adds macos-14 and ubuntu-22.04 jobs. This seems to add ~15min to total runtime.
1 parent a09f291 commit a1af64c

File tree

2 files changed

+16
-3
lines changed

2 files changed

+16
-3
lines changed

.github/workflows/ci.yml

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,19 @@ jobs:
199199
strategy:
200200
fail-fast: false
201201
matrix:
202-
os: [ ubuntu-22.04, macos-12, macos-14, windows-2022 ]
202+
include:
203+
- os: macos-12
204+
debug: false
205+
- os: macos-14
206+
debug: false
207+
- os: macos-14
208+
debug: true
209+
- os: ubuntu-22.04
210+
debug: false
211+
- os: ubuntu-22.04
212+
debug: true
213+
- os: windows-2022
214+
debug: false
203215
defaults:
204216
run:
205217
shell: bash
@@ -253,7 +265,9 @@ jobs:
253265
working-directory: modflow6
254266
run: |
255267
setupargs=""
256-
if [[ "${{ matrix.os }}" == "macos-14" ]]; then
268+
if [[ "${{ matrix.debug }}" == "true" ]]; then
269+
setupargs="-Ddebug=true -Doptimization=0"
270+
elif [[ "${{ matrix.os }}" == "macos-14" ]]; then
257271
setupargs="-Doptimization=1"
258272
fi
259273
pixi run setup builddir $setupargs

autotest/test_prt_disv1.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,6 @@ def compare_output(name, mf6_pls, mp7_pls, mp7_eps):
414414
if "bprp" not in name:
415415
# pollock's method should be (nearly) identical
416416
mf6_pls_plck = mf6_pls[mf6_pls.particlegroup == 1]
417-
# import pdb; pdb.set_trace()
418417
assert mf6_pls_plck.shape == mp7_pls.shape
419418
assert np.allclose(mf6_pls_plck, mp7_pls, atol=1e-3)
420419

0 commit comments

Comments
 (0)