You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The logic around project uploads, the grace period, etc. is in need of some looking at.
For example, the time left for each student to reupload their project is determined by looking up the time at which the job to end the grace period will run:
and whilst there's nothing actually wrong with this (in normal use, the grace_deadline job sets a flag that prevents the frontend from querying this API endpoint), it would be a lot nicer if the calculation of "when should the grace period end" was separated from the actual action of scheduling the job to end it.
It also looks like there has been some miscommunication and/or indecision about how the grace period should actually work, as there's a lot of copy in the frontend about having 3 days after you upload the project to reupload it, whereas the backend schedules the grace_deadline job for either 1 or 3 days after the final upload deadline, depending on the rotation.
The text was updated successfully, but these errors were encountered:
The logic around project uploads, the grace period, etc. is in need of some looking at.
For example, the time left for each student to reupload their project is determined by looking up the time at which the job to end the grace period will run:
backend/cogs/routes/api/projects.py
Lines 392 to 395 in 616da09
and whilst there's nothing actually wrong with this (in normal use, the
grace_deadline
job sets a flag that prevents the frontend from querying this API endpoint), it would be a lot nicer if the calculation of "when should the grace period end" was separated from the actual action of scheduling the job to end it.It also looks like there has been some miscommunication and/or indecision about how the grace period should actually work, as there's a lot of copy in the frontend about having 3 days after you upload the project to reupload it, whereas the backend schedules the
grace_deadline
job for either 1 or 3 days after the final upload deadline, depending on the rotation.The text was updated successfully, but these errors were encountered: