From 990db7bac7c92ddfbe84733417773f31926a92b8 Mon Sep 17 00:00:00 2001
From: Ronnie Barnard <ronnieb@iprolive.com>
Date: Thu, 7 Jan 2016 12:22:50 -0800
Subject: [PATCH 1/3] Added TextAlignment

---
 testsite/Controls/textbox.fap | 4 +++-
 themes/Metro.theme.xml        | 7 +++++--
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/testsite/Controls/textbox.fap b/testsite/Controls/textbox.fap
index 8c7cc0d2..2fbfcd2c 100644
--- a/testsite/Controls/textbox.fap
+++ b/testsite/Controls/textbox.fap
@@ -8,6 +8,7 @@
             <RowDefinition Height="Auto" />
             <RowDefinition Height="Auto" />
             <RowDefinition Height="Auto" />
+            <RowDefinition Height="Auto" />
             <RowDefinition />
         </Grid.RowDefinitions>
         <TextBox Grid.Row="0" Margin="5" Text="Enter Text here!" Background="Yellow" />
@@ -26,6 +27,7 @@
             <TextBox x:Name="SelectionText5" Margin="0,5" Text="DefaultSelectAll" SelectionOnFocus="DefaultSelectAll" />
         </StackPanel>
         
-        <TextBox x:Name="BigTextBox" Grid.Row="4" Margin="5" Text="Enter Text here!" AcceptsReturn="True" TextWrapping="Wrap" />
+        <TextBox Grid.Row="4" Margin="5" Text="10.00" Background="White" Width="150" TextAlignment="Right" HorizontalAlignment="Left" />
+        <TextBox x:Name="BigTextBox" Grid.Row="5" Margin="5" Text="Enter Text here!" AcceptsReturn="True" TextWrapping="Wrap" VerticalContentAlignment="Top" />
     </Grid>
 </Application>
\ No newline at end of file
diff --git a/themes/Metro.theme.xml b/themes/Metro.theme.xml
index 5356ce5c..7496dfca 100755
--- a/themes/Metro.theme.xml
+++ b/themes/Metro.theme.xml
@@ -644,6 +644,7 @@
         <Setter Property="BorderBrush" Value="{StaticResource TextBoxBorderBrush}"/>
         <Setter Property="VerticalContentAlignment" Value="Center"/>
         <Setter Property="HorizontalContentAlignment" Value="Left"/>
+        <Setter Property="TextAlignment" Value="Left"/>
         <Setter Property="Template">
             <Setter.Value>
                 <ControlTemplate TargetType="TextBox">
@@ -722,10 +723,12 @@
                         <Grid Margin="0,1,0,0">
                             <Border x:Name="ReadOnlyVisualElement" Background="{StaticResource ReadOnlyBrush}"
                                     Opacity="0"/>
-                            <Grid>
+                            <Grid HorizontalAlignment="{TemplateBinding TextAlignment}">
                                 <ScrollViewer x:Name="ContentElement" BorderThickness="0" IsTabStop="False"
                                               Margin="4,0,2,2" VerticalAlignment="{TemplateBinding VerticalContentAlignment}" Background="{x:Null}"
-                                              HorizontalAlignment="{TemplateBinding HorizontalContentAlignment}"/>
+                                              HorizontalAlignment="{TemplateBinding HorizontalContentAlignment}" 
+                                              VerticalScrollBarVisibility="Visible"
+                                              HorizontalScrollBarVisibility="Disabled"/>
                             </Grid>
                         </Grid>
                         <Rectangle x:Name="DisabledVisualElement" Stroke="{StaticResource ControlsDisabledBrush}"

From 3f1fc2778f092660be8c9f648e6b222404f227a8 Mon Sep 17 00:00:00 2001
From: Ronnie Barnard <ronnieb@iprolive.com>
Date: Mon, 11 Jan 2016 09:27:32 -0800
Subject: [PATCH 2/3] Visibility set to Auto instead of Visible

---
 themes/Metro.theme.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/themes/Metro.theme.xml b/themes/Metro.theme.xml
index 7496dfca..f1d4e8ab 100755
--- a/themes/Metro.theme.xml
+++ b/themes/Metro.theme.xml
@@ -727,7 +727,7 @@
                                 <ScrollViewer x:Name="ContentElement" BorderThickness="0" IsTabStop="False"
                                               Margin="4,0,2,2" VerticalAlignment="{TemplateBinding VerticalContentAlignment}" Background="{x:Null}"
                                               HorizontalAlignment="{TemplateBinding HorizontalContentAlignment}" 
-                                              VerticalScrollBarVisibility="Visible"
+                                              VerticalScrollBarVisibility="Auto"
                                               HorizontalScrollBarVisibility="Disabled"/>
                             </Grid>
                         </Grid>

From 4730f2ad3b9946d4b3402c6792b973e9b6ad1177 Mon Sep 17 00:00:00 2001
From: Ronnie Barnard <ronnieb@iprolive.com>
Date: Fri, 22 Jan 2016 11:26:40 -0800
Subject: [PATCH 3/3] Fixed scrollbars on text box

---
 src/Controls/Internal/TextBoxContentProxy.ts |  9 ++++++--
 src/Controls/TextBoxBase.ts                  |  1 +
 testsite/Controls/textbox.fap                |  4 ++--
 themes/Metro.theme.xml                       | 24 ++++++++++++++------
 4 files changed, 27 insertions(+), 11 deletions(-)

diff --git a/src/Controls/Internal/TextBoxContentProxy.ts b/src/Controls/Internal/TextBoxContentProxy.ts
index b85a43aa..7c28cfd0 100644
--- a/src/Controls/Internal/TextBoxContentProxy.ts
+++ b/src/Controls/Internal/TextBoxContentProxy.ts
@@ -1,6 +1,7 @@
 module Fayde.Controls.Internal {
     export class TextBoxContentProxy {
         private $$element: FrameworkElement = null;
+        private $$scrollElement: FrameworkElement = null;
 
         setElement(fe: FrameworkElement, view: TextBoxView) {
             this.$$element = fe;
@@ -19,9 +20,13 @@ module Fayde.Controls.Internal {
                 console.warn("TextBox does not have a valid content element.");
             }
         }
+        
+        setScrollElement(fe: FrameworkElement){
+            this.$$scrollElement = fe;
+        }
 
         setHorizontalScrollBar(sbvis: ScrollBarVisibility) {
-            var ce = this.$$element;
+            var ce = this.$$scrollElement;
             if (!ce)
                 return;
             var ceType = (<any>ce).constructor;
@@ -32,7 +37,7 @@ module Fayde.Controls.Internal {
         }
 
         setVerticalScrollBar(sbvis: ScrollBarVisibility) {
-            var ce = this.$$element;
+            var ce = this.$$scrollElement;
             if (!ce)
                 return;
             var ceType = (<any>ce).constructor;
diff --git a/src/Controls/TextBoxBase.ts b/src/Controls/TextBoxBase.ts
index 04ffcab0..72d90c7c 100755
--- a/src/Controls/TextBoxBase.ts
+++ b/src/Controls/TextBoxBase.ts
@@ -104,6 +104,7 @@ module Fayde.Controls {
         OnApplyTemplate() {
             super.OnApplyTemplate();
             this.$ContentProxy.setElement(<FrameworkElement>this.GetTemplateChild("ContentElement", FrameworkElement), this.$View);
+            this.$ContentProxy.setScrollElement(<FrameworkElement>this.GetTemplateChild("ScrollElement", FrameworkElement));
         }
 
         OnLostFocus(e: RoutedEventArgs) {
diff --git a/testsite/Controls/textbox.fap b/testsite/Controls/textbox.fap
index 2fbfcd2c..6db65c89 100644
--- a/testsite/Controls/textbox.fap
+++ b/testsite/Controls/textbox.fap
@@ -12,7 +12,7 @@
             <RowDefinition />
         </Grid.RowDefinitions>
         <TextBox Grid.Row="0" Margin="5" Text="Enter Text here!" Background="Yellow" />
-        <TextBox Grid.Row="1" Margin="5" Text="Enter Text here!" Background="Orange" TextWrapping="Wrap" HorizontalAlignment="Left" Width="100" Height="50" VerticalScrollBarVisibility="Auto" />
+        <TextBox Grid.Row="1" Margin="5" Text="Enter Text here!" AcceptsReturn="True" Background="Orange" TextWrapping="Wrap" HorizontalAlignment="Left" Width="400" Height="80" VerticalScrollBarVisibility="Visible" />
         <StackPanel Orientation="Horizontal" Grid.Row="2">
             <TextBlock Margin="5" Text="{Binding ElementName=BigTextBox, Path=SelectionStart}" />
             <TextBlock Margin="5" Text="{Binding ElementName=BigTextBox, Path=SelectionLength}" />
@@ -28,6 +28,6 @@
         </StackPanel>
         
         <TextBox Grid.Row="4" Margin="5" Text="10.00" Background="White" Width="150" TextAlignment="Right" HorizontalAlignment="Left" />
-        <TextBox x:Name="BigTextBox" Grid.Row="5" Margin="5" Text="Enter Text here!" AcceptsReturn="True" TextWrapping="Wrap" VerticalContentAlignment="Top" />
+        <TextBox x:Name="BigTextBox" Grid.Row="5" Margin="5" Text="Enter Text here!" AcceptsReturn="True" TextWrapping="Wrap" VerticalContentAlignment="Top" VerticalScrollBarVisibility="Auto" />
     </Grid>
 </Application>
\ No newline at end of file
diff --git a/themes/Metro.theme.xml b/themes/Metro.theme.xml
index f1d4e8ab..429d830e 100755
--- a/themes/Metro.theme.xml
+++ b/themes/Metro.theme.xml
@@ -723,13 +723,23 @@
                         <Grid Margin="0,1,0,0">
                             <Border x:Name="ReadOnlyVisualElement" Background="{StaticResource ReadOnlyBrush}"
                                     Opacity="0"/>
-                            <Grid HorizontalAlignment="{TemplateBinding TextAlignment}">
-                                <ScrollViewer x:Name="ContentElement" BorderThickness="0" IsTabStop="False"
-                                              Margin="4,0,2,2" VerticalAlignment="{TemplateBinding VerticalContentAlignment}" Background="{x:Null}"
-                                              HorizontalAlignment="{TemplateBinding HorizontalContentAlignment}" 
-                                              VerticalScrollBarVisibility="Auto"
-                                              HorizontalScrollBarVisibility="Disabled"/>
-                            </Grid>
+                            <ScrollViewer BorderThickness="0"
+                                          x:Name="ScrollElement" 
+                                          IsTabStop="False"
+                                          Background="{x:Null}"
+                                          VerticalAlignment="Stretch" 
+                                          HorizontalAlignment="Stretch" 
+                                          VerticalScrollBarVisibility="Auto"
+                                          HorizontalScrollBarVisibility="Disabled">
+                                <ScrollViewer x:Name="ContentElement" 
+                                              BorderThickness="0" 
+                                              IsTabStop="False"
+                                              Margin="4,0,2,2" 
+                                              Background="{x:Null}"
+                                              HorizontalAlignment="{TemplateBinding TextAlignment}"
+                                              VerticalScrollBarVisibility="Disabled"
+                                              HorizontalScrollBarVisibility="Disabled" />
+                            </ScrollViewer>
                         </Grid>
                         <Rectangle x:Name="DisabledVisualElement" Stroke="{StaticResource ControlsDisabledBrush}"
                                    StrokeThickness="{TemplateBinding BorderThickness}"