Skip to content

Commit ca3d96a

Browse files
authored
Merge pull request #63 from sohomdatta1/github-action-hang
Dont send over the complete diff since the self-hosted runner hangs
2 parents c742375 + 7436820 commit ca3d96a

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

.github/workflows/chromium-build.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,15 +61,16 @@ jobs:
6161
}
6262
};
6363
await exec.exec( 'git', [ '--no-pager', 'diff', process.env.oldCommit + '..' + process.env.currentCommit, 'patches', 'builder', '.github' ], options );
64-
core.setOutput('diff', btoa(output));
64+
core.setOutput('diff', output[0] || 'empty');
65+
# Hack: We send the first letter or the string 'empty' since Github runners hang if we send over the entire diff
6566
- name: Should we publish ?
6667
id: shouldPublish
6768
uses: actions/github-script@v6
6869
env:
6970
GIT_DIFF: ${{ steps.diff.outputs.diff }}
7071
with:
7172
script: |
72-
const shouldPublish = '${{ steps.get_release.outputs.chromeReleaseVersion }}' != '${{ steps.get_release.outputs.fullVersion }}' || '${{ steps.get_release.outputs.currentGitCommit }}' != '${{ steps.get_release.outputs.commit }}' || process.env.GIT_DIFF != '';
73+
const shouldPublish = '${{ steps.get_release.outputs.chromeReleaseVersion }}' != '${{ steps.get_release.outputs.fullVersion }}' || '${{ steps.get_release.outputs.currentGitCommit }}' != '${{ steps.get_release.outputs.commit }}' || process.env.GIT_DIFF != 'empty';
7374
console.log(`shouldPublish: ${shouldPublish}`);
7475
core.setOutput('shouldPublish', shouldPublish);
7576
- name: Build VisibleV8

0 commit comments

Comments
 (0)