Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement two-ion model for >= v9 compatibility #254

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

Implement two-ion model for >= v9 compatibility #254

wants to merge 16 commits into from

Conversation

wtbarnes
Copy link
Owner

@wtbarnes wtbarnes commented Jan 12, 2024 •
edited
Loading

Fixes #234
Fixes #224

This PR represents the major changes needed for compatibility with >=v9 of CHIANTI.

  • Add n_levels property
  • Add n_transitions property
  • Fix bug in burgess_tully_descale to never return object-type arrays
  • Review how indexing into rate matrices is done (e.g. vectorize where)
  • Separate out code for building coefficient matrices
  • Implement ionization rates in coefficient matrix
  • Implement level-resolved radiative recombination
  • Implement autoionization rates in coefficient matrix
  • Dielectronic capture
  • Dielectronic recombination
  • Refactor how depopulation terms are added along the diagonal
  • Logic for excluding ionization/recombination correction factor when two-ion model is used
  • Logic for turning on/off two-ion model
  • Tests for two-ion model
  • Docs? (see also Add explanation page #226)
  • IDL comparison tests for two-ion model
  • Review where _elvlc is used explicitly (favor levels) Create an issue to replace all usage of _elvlc with self.levels (or indexing)
  • Create an issue to replace all usage of _wgfa with self.transitions
  • Write a high-level summary of the changes in this PR description

@wtbarnes wtbarnes added WIP Work in progress Ion Anything related to the Ion object labels Jan 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2024 •
edited by codecov bot
Loading

Codecov Report

Attention: Patch coverage is 68.80000% with 78 lines in your changes missing coverage. Please review.

Project coverage is 88.65%. Comparing base (63a2778) to head (5dd8b8b).

Files with missing lines Patch % Lines
fiasco/ions.py 58.06% 78 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
- Coverage   90.71%   88.65%   -2.06%     
==========================================
  Files          41       41              
  Lines        3456     3588     +132     
==========================================
+ Hits         3135     3181      +46     
- Misses        321      407      +86

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wtbarnes wtbarnes mentioned this pull request Feb 21, 2024
Merged
@wtbarnes wtbarnes force-pushed the collisional-radiative-effects branch from 864203c to 0f80c04 Compare January 16, 2025 20:00
@wtbarnes wtbarnes force-pushed the collisional-radiative-effects branch from 0f80c04 to b81199d Compare January 28, 2025 18:22
This was referenced Feb 5, 2025
Open
Open
@wtbarnes wtbarnes changed the title Incorporate collisional radiative effects Implement two-ion model for >= v9 compatibility Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Ion Anything related to the Ion object WIP Work in progress
Projects
None yet
Milestone
No milestone
2 participants
@wtbarnes @codecov-commenter