Skip to content

Commit d66b77a

Browse files
Merge pull request #86 from wtsi-npg/devel
Release 1.19
2 parents 54d31c1 + 6638a24 commit d66b77a

File tree

4 files changed

+16
-2
lines changed

4 files changed

+16
-2
lines changed

Changes

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
release 1.19
2+
- cope with unknown sort order in header
3+
14
release 1.18
25
- new command line option CHANGE_RG_NAME default false
36
- NB this is a change to previous behaviour, where it was always true

nbproject/project.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ file.reference.jackson-core-2.0.0.jar=lib/jackson/jackson-core-2.0.0.jar
3333
file.reference.jackson-databind-2.0.0.jar=lib/jackson/jackson-databind-2.0.0.jar
3434
file.reference.picard.jar=lib/picard/picard-1.96.jar
3535
file.reference.sam.jar=lib/picard/sam-1.96.jar
36-
illumina2bam.version=1.18
36+
illumina2bam.version=1.19
3737
includes=**
3838
jar.compress=false
3939
javac.classpath=\

src/uk/ac/sanger/npg/picard/BamIndexDecoder.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -354,6 +354,11 @@ public void generateOutputFile(SAMFileHeader header) {
354354
+ OUTPUT_FORMAT;
355355
final SAMFileHeader perBarcodeOutputHeader = outputHeader.clone();
356356
perBarcodeOutputHeader.setReadGroups(readGroupList);
357+
try {
358+
perBarcodeOutputHeader.getSortOrder();
359+
} catch(IllegalArgumentException e) {
360+
perBarcodeOutputHeader.setSortOrder(SAMFileHeader.SortOrder.unsorted);
361+
}
357362
final SAMFileWriter outPerBarcode = new SAMFileWriterFactory().makeSAMOrBAMWriter(perBarcodeOutputHeader, true, new File(barcodeBamOutputName));
358363
outputList.put(barcode, outPerBarcode);
359364
}
@@ -363,6 +368,12 @@ public void generateOutputFile(SAMFileHeader header) {
363368
if (OUTPUT != null) {
364369
log.info("Open output file with header: " + OUTPUT.getName());
365370
outputHeader.setReadGroups(fullReadGroupList);
371+
try {
372+
outputHeader.getSortOrder();
373+
} catch(IllegalArgumentException e) {
374+
outputHeader.setSortOrder(SAMFileHeader.SortOrder.unsorted);
375+
}
376+
366377
this.out = new SAMFileWriterFactory().makeSAMOrBAMWriter(outputHeader, true, OUTPUT);
367378
}
368379

src/uk/ac/sanger/npg/picard/PicardCommandLine.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
*/
3333
public abstract class PicardCommandLine extends CommandLineProgram {
3434

35-
public static final String version = "1.17";
35+
public static final String version = "1.19";
3636

3737
/**
3838
* Generate Program Record for this program itself

0 commit comments

Comments
 (0)