Bugfixes in pure python aui where rapid layout changes may trigger calls to destroyed C++ objets. #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two cases in pure-python aui where rapid layout changes may cause errors by trying to use C++ objects that have been destroyed.
The details of the errors are given at #2473
This is an improved version of that older PR that I retracted because testing showed it was not sufficient to to resolve the problem. I and others have been testing this current PR as part of the wxPython-Meticy release. The issue appears to be fully resolved. This PR is safe to apply since it simply tests that the underlying C++ objects exist and are valid before they are used.