Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more serial:// options #21

Open
wybiral opened this issue Jul 1, 2018 · 1 comment
Open

Add more serial:// options #21

wybiral opened this issue Jul 1, 2018 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@wybiral
Copy link
Owner

wybiral commented Jul 1, 2018

The serial package being used supports multiple options beyond the baud rate which might be useful to expose as optional arguments.

We should add more options to the serial protocol. See comment below.

@wybiral wybiral added enhancement New feature or request good first issue Good for newcomers labels Jul 1, 2018
@wybiral
Copy link
Owner Author

wybiral commented Jul 10, 2018

That serial package is no longer being used in v2 because of #27

The one currently being used is this package.

Good options to provide would probably be:

  • Data bits (maps to serial.Config.Size)
  • Parity (maps to serial.Config.Parity)
  • Stop bits (maps to serial.Config.StopBits)

The current defaults are for 8-N-1. It's probably a good idea to look at other tools that take in these options and see if there's an implied standard for supplying these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant