diff --git a/src/main/java/me/xginko/pumpkinpvpreloaded/modules/effects/FireworkEffects.java b/src/main/java/me/xginko/pumpkinpvpreloaded/modules/effects/FireworkEffects.java index 0807b85..c39d46e 100644 --- a/src/main/java/me/xginko/pumpkinpvpreloaded/modules/effects/FireworkEffects.java +++ b/src/main/java/me/xginko/pumpkinpvpreloaded/modules/effects/FireworkEffects.java @@ -66,7 +66,7 @@ public FireworkEffects() { int tries = 0; while (secondary_color.equals(primary_color)) { // Avoid rolling the same color if (tries > 100) break; // Avoid infinite loop on bad config - secondary_color = parsedColors.get(new Random().nextInt(parsedColors.size())); + secondary_color = parsedColors.get(new Random().nextInt(parsedColors.size() + 1) - 1); tries++; } this.fireWorkEffects.add(FireworkEffect.builder() @@ -100,6 +100,11 @@ public void disable() { HandlerList.unregisterAll(this); } + private FireworkEffect getRandomEffect() { + // Try to get a 0 naturally without having an origin value in Random (I hate using old jdk's) + return this.fireWorkEffects.get(new Random().nextInt(this.fireWorkEffects.size() + 1) - 1); + } + @EventHandler(priority = EventPriority.LOWEST) private void onPostPumpkinExplode(PostPumpkinExplodeEvent event) { if (event.hasExploded()) { @@ -125,9 +130,4 @@ private void onPostPumpkinHeadExplode(PostPumpkinHeadEntityExplodeEvent event) { firework.detonate(); } } - - private FireworkEffect getRandomEffect() { - // Try to get a 0 naturally without having an origin value in Random (I hate using old jdk's) - return this.fireWorkEffects.get(new Random().nextInt(this.fireWorkEffects.size() + 1) - 1); - } } \ No newline at end of file