Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] [HLS] manifests with #EXT-X-PROGRAM-DATE-TIME tags #1719

Open
mtr81 opened this issue Nov 6, 2024 · 3 comments
Open

[Feature request] [HLS] manifests with #EXT-X-PROGRAM-DATE-TIME tags #1719

mtr81 opened this issue Nov 6, 2024 · 3 comments
Labels
require discussion Type: Feature non-breaking change which adds functionality

Comments

@mtr81
Copy link

mtr81 commented Nov 6, 2024

Describe the feature

Adding a ISA property to disable the inclusion of #EXT-X-PROGRAM-DATE-TIME tags in the playback process.

Motivation

I noticed that ISA has a problem with playback HLS manifests containing #EXT-X-PROGRAM-DATE-TIME tags.
Currently, the only solution is to edit manifests using a proxy. Also inpustream ffmpegdirect player correctly plays manifests with these tags...

Are you willing to contribute in development?

No

Should a possible backport be considered?

No

@mtr81 mtr81 added the Type: Feature non-breaking change which adds functionality label Nov 6, 2024
@CastagnaIT
Copy link
Collaborator

you havent described nor provided files that explains the underlying reasons why the #EXT-X-PROGRAM-DATE-TIME must be deleted/ignored, as far as i know this could also be an unresolved bug that you are trying to hide instead of solve it
i cannot accept this request as is

@mtr81
Copy link
Author

mtr81 commented Nov 7, 2024

Case no. 1 [incorrect data on counter and thus a problem with video scrolling]:
manifest_1730949530_master.txt
manifest_1730949532_child-video.txt
You can see on counter:

  • start time: 11:16:21
  • end time: 11:31:16

After removing tags #EXT-X-PROGRAM-DATE-TIME (by proxy) Kodi gives correct data:
00:00:00 / 00:14:55

Case no. 2 [LIVE STREAM - playbacks stops after 13 sec. and then Kodi crashes]
log.txt
manifest_1730951188_child-video.txt
manifest_1730951188_master.txt
manifest_1730951193_child-video.txt
manifest_1730951198_child-video.txt
manifest_1730951203_child-video.txt
manifest_1730951208_child-video.txt
manifest_1730951213_child-video.txt

Also in this case, removing the tags solves the problem...

@CastagnaIT
Copy link
Collaborator

these cases require more investigations

case 1: its missing VOD tag so assumed as LIVE, but there is a EXT-X-ENDLIST tag, its the first time that i see an HLS live video that end, i think has been never full tested, "live to vod" transitions has been always problematic case and could be cause of problems

case 2: crashes need to be investigated clearly something is not working correctly

i could provide a way to force disable parsing EXT-X-PROGRAM-DATE-TIME
but its not a solution, it just hide problems,
other users can open new issues about same problems

these are videos that i can play by myself if you provide a link/addon or other way also in PVT?
would make it much easier for me to debug and try to find a better solution, if im able, so to try avoid implementing a workaround to manually set a property to ignore EXT-X-PROGRAM-DATE-TIME

if not possible,
at least shoud be solved the crash, if so, i can provide some instructions to try get a debug dump crash log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
require discussion Type: Feature non-breaking change which adds functionality
Projects
None yet
Development

No branches or pull requests

2 participants