Remove dependency on icu4j

Author: NichtStudioCode

gradle/libs.versions.toml

@@ -27,7 +27,6 @@ commons-reflection = { group = "xyz.xenondevs.commons", name = "commons-reflecti
 configurate-yaml = { group = "org.spongepowered", name = "configurate-yaml", version = "4.1.2" }
 cosmic-binary-format = { group = "xyz.xenondevs.cbf", name = "cosmic-binary-format", version.ref = "cbf" }
 fuzzywuzzy = { group = "me.xdrop", name = "fuzzywuzzy", version = "1.4.0" }
-icu4j = { group = "com.ibm.icu", name = "icu4j", version = "76.1" }
 invui-kotlin = { group = "xyz.xenondevs.invui", name = "invui-kotlin", version.ref = "invui" }
 jgrapht-core = { group = "org.jgrapht", name = "jgrapht-core", version.ref = "jgrapht" }
 jgrapht-io = { group = "org.jgrapht", name = "jgrapht-io", version.ref = "jgrapht" }

nova/build.gradle.kts

@@ -18,7 +18,6 @@ dependencies {
     novaLoaderApi(libs.bundles.xenondevs.commons)
     novaLoaderApi(libs.invui.kotlin)
     novaLoaderApi(libs.joml.primitives)
-    novaLoaderApi(libs.icu4j)
 
     // internal dependencies
     compileOnly(project(":nova-api"))

nova/src/main/kotlin/xyz/xenondevs/nova/resources/builder/layout/item/SelectItemModelBuilder.kt

@@ -1,8 +1,5 @@
 package xyz.xenondevs.nova.resources.builder.layout.item
 
-import com.ibm.icu.text.SimpleDateFormat
-import com.ibm.icu.util.TimeZone
-import com.ibm.icu.util.ULocale
 import net.kyori.adventure.key.Key
 import org.bukkit.entity.EntityType
 import xyz.xenondevs.nova.registry.RegistryElementBuilderDsl
@@ -150,14 +147,23 @@ sealed class SelectItemModelProperty<T>(internal val property: SelectItemModel.P
     /**
      * Returns the current time in [timeZone] formatted according to the given [pattern]
      *
-     * @param timeZone The time zone to use for formatting the time.
-     * @param locale The locale to use for formatting the time, or `null` for the root locale.
-     * @param pattern The pattern to use for formatting the time, interpreted by [SimpleDateFormat].
+     * @param timeZone The time zone to use for formatting the time. If not present, defaults to the timezone set by the client.
+     * Examples:
+     * - `Europe/Stockholm`
+     * - `GMT+0:45`
+     * @param locale The locale to use for formatting the time, or `""` for the root locale.
+     * Examples:
+     * - `en_US`: English language (used for things like week names), formating as in the USA.
+     * - `cs_AU@numbers=thai;calendar=japanese`: Czech language, Australian formatting, Thai numerals and Japanese calendar
+     * @param pattern The pattern to be used for formatting the time.
+     * Examples:
+     * - `yyyy-MM-dd`: 4-digit year number, then 2-digit month number, then 2-digit day of month number, all zero-padded if needed, separated by `-`.
+     * - `HH:mm:ss`: current time (hours, minutes, seconds), 24-hour cycle, all zero-padded to 2 digits of needed, separated by `:`.
      */
     class LocalTime(
         private val pattern: String,
-        private val timeZone: TimeZone,
-        private val locale: ULocale? = null
+        private val timeZone: String? = null,
+        private val locale: String = ""
     ) : SelectItemModelProperty<String>(SelectItemModel.Property.LOCAL_TIME) {
 
         override fun toString(value: String) = value
@@ -167,8 +173,8 @@ sealed class SelectItemModelProperty<T>(internal val property: SelectItemModel.P
                 property,
                 cases,
                 fallback,
-                locale = locale?.name ?: "",
-                timeZone = timeZone.id,
+                locale = locale,
+                timeZone = timeZone,
                 pattern = pattern
             )