From 78155bf97149bfde8842f61632872d0f57c987fb Mon Sep 17 00:00:00 2001
From: NichtStudioCode <51272202+NichtStudioCode@users.noreply.github.com>
Date: Wed, 21 Aug 2024 17:24:23 +0200
Subject: [PATCH] Set BUFFER as default connection type for vanilla tile
 entities

This was changed to INSERT in eb7c87b2f4267e5946c58a022999fed50041126e in an attempt to improve performance for setups where users accidentally left default settings. This should no longer be necessary since 52a6149f46bbcb089c0bc92129b30bc5f11b4566 .
Using BUFFER as default connection type is also more user-friendly, as the side-configuration of vanilla tile entities can only be changed via cable connections or wrench, preventing simple setups like chest on top of custom block for input from working.
---
 .../network/type/item/holder/VanillaItemHolder.kt         | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/nova/src/main/kotlin/xyz/xenondevs/nova/world/block/tileentity/network/type/item/holder/VanillaItemHolder.kt b/nova/src/main/kotlin/xyz/xenondevs/nova/world/block/tileentity/network/type/item/holder/VanillaItemHolder.kt
index 5689217d992..0df5e1f121f 100644
--- a/nova/src/main/kotlin/xyz/xenondevs/nova/world/block/tileentity/network/type/item/holder/VanillaItemHolder.kt
+++ b/nova/src/main/kotlin/xyz/xenondevs/nova/world/block/tileentity/network/type/item/holder/VanillaItemHolder.kt
@@ -7,11 +7,11 @@ import xyz.xenondevs.commons.collections.enumMap
 import xyz.xenondevs.commons.collections.enumSet
 import xyz.xenondevs.commons.provider.Provider
 import xyz.xenondevs.commons.provider.mutable.defaultsToLazily
+import xyz.xenondevs.nova.util.CUBE_FACES
 import xyz.xenondevs.nova.world.block.tileentity.network.type.NetworkConnectionType
 import xyz.xenondevs.nova.world.block.tileentity.network.type.item.ItemFilter
 import xyz.xenondevs.nova.world.block.tileentity.network.type.item.holder.DefaultItemHolder.Companion.DEFAULT_CHANNELS
 import xyz.xenondevs.nova.world.block.tileentity.network.type.item.inventory.NetworkedInventory
-import xyz.xenondevs.nova.util.CUBE_FACES
 
 internal abstract class VanillaItemHolder(
     compound: Provider<Compound>
@@ -19,9 +19,9 @@ internal abstract class VanillaItemHolder(
     
     override val mergedInventory: NetworkedInventory? = null
     
-    override val connectionConfig: MutableMap<BlockFace, NetworkConnectionType> by
-    compound.entry<MutableMap<BlockFace, NetworkConnectionType>>("connectionConfig")
-        .defaultsToLazily { CUBE_FACES.associateWithTo(enumMap()) { NetworkConnectionType.INSERT } }
+    override val connectionConfig: MutableMap<BlockFace, NetworkConnectionType>
+        by compound.entry<MutableMap<BlockFace, NetworkConnectionType>>("connectionConfig")
+            .defaultsToLazily { CUBE_FACES.associateWithTo(enumMap()) { NetworkConnectionType.BUFFER } }
     
     override val allowedFaces: Set<BlockFace>
         get() = connectionConfig.mapNotNullTo(enumSet()) { (face, type) ->