Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A bug of CamerControl #298

Open
jacklincao opened this issue Dec 17, 2018 · 2 comments
Open

A bug of CamerControl #298

jacklincao opened this issue Dec 17, 2018 · 2 comments

Comments

@jacklincao
Copy link

I find a bug in line 1113 if (down) { panVy += elapsed * keyboardPanRate; } in src/controls/cameraControl.js, when I hold down X to let cameraControl down. And I fixed this problem by modifying the expression if (down) { panVy += -elapsed * keyboardPanRate; }, I have make a PR about it, Please see if my modification is correct. Thanks.
@yihoo
Copy link

yihoo commented Mar 1, 2019

I confirmed this bug, my solution is changing += into -=;
I think two solutions are equal.

@Swaggaaa
Copy link
Contributor

Swaggaaa commented May 8, 2019

#311
#312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Swaggaaa @yihoo @jacklincao