Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations showing when the mesh is behind the camera #313

Open
Swaggaaa opened this issue May 8, 2019 · 0 comments
Open

Annotations showing when the mesh is behind the camera #313

Swaggaaa opened this issue May 8, 2019 · 0 comments

Comments

@Swaggaaa
Copy link
Contributor

Swaggaaa commented May 8, 2019

Describe the bug
I'm not referring to the "occludable" property but to the mesh being behind the camera. When converting the world positions to the canvas positions in order to draw the annotation, it ignores whether the mesh attached to the annotation is positioned in front or behind the camera, resulting in "weird" behaviours and the annotation showing when looking at the opposite direction.

To Reproduce
Steps to reproduce the behavior:

  1. Attach an annotation to any model.
  2. Look at the annotation's mesh and then turn away 90 degrees
  3. The horizontal scrollbar should appear.
  4. Keep turning away another 90 degrees.
  5. The horizontal scrollbar disappeared but now we can see the annotation in the middle of the screen. However, the mesh attached to it is behind us.

Expected behavior
Annotations should not be rendered when the mesh attached to it is out of sight (not occluded but actually outside the camera FOV).

Screenshots
https://imgur.com/a/OEOa6P5

Desktop (please complete the following information):

  • OS: Windows 10 (1809)
  • Google Chrome
  • 74

Additional context
I'll try to fix this later and update this ticket if I do so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant