Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff seems to contain unchanged chunks #48

Open
foresterre opened this issue Oct 14, 2024 · 1 comment · May be fixed by #88
Open

Diff seems to contain unchanged chunks #48

foresterre opened this issue Oct 14, 2024 · 1 comment · May be fixed by #88
Labels
bug Something isn't working

Comments

@foresterre
Copy link

Summary

The diff seems to contain unchanged lines, as both added and removed

Expected:

Diff to be empty, or only show what changed.

Actual:

Shows all lines in file as both added and deleted.
I think this is also the case for changed files in at least this example, but it's a lot easier to spot in unchanged files.

Examples:

Example screenshot:

image

I also checked for whitespace changes:

image

@xfbs
Copy link
Owner

xfbs commented Oct 14, 2024

Hey, thanks for this bug report! I'll look into it. It might also be a bug with the similar crate that we use for generating the diff.

@xfbs xfbs added the bug Something isn't working label Oct 14, 2024
@HWienhold HWienhold linked a pull request Nov 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants