Repl can't work with workspace

[zavakid]

When I debug with a workspace's crate project, I found:

error: Failed to create REPL: Failed to add path dep: 
Message("error: failed to get `ferrumpy_snapshot`
Caused by:
  failed to load source for dependency `ferrumpy_snapshot`
Caused by:
  Unable to update /var/folders/yc/k7w5_ts978d312rh4qss49f40000gn/T/ferrumpy_lib_27996
Caused by:
  failed to parse manifest at `/var/folders/yc/k7w5_ts978d312rh4qss49f40000gn/T/ferrumpy_lib_27996/Cargo.toml`
Caused by:
  error inheriting `bitflags` from workspace root manifest's `workspace.dependencies.bitflags`
Caused by:
  failed to find a workspace root"
)

the project in /var/folders/yc/k7w5_ts978d312rh4qss49f40000gn/T/ferrumpy_lib_27996 is just a crate in my workspace, the dependency is something like this:

[dependencies]
serde = { version = "1", features = ["derive"] }
serde_json = "1"
bitflags = { workspace = true }
compact_str = { workspace = true }

[xiaoniaoyouhuajiang]

"This issue occurs because I didn't account for dependency inheritance in workspace projects. I can implement a fix by parsing the Cargo.toml of the root workspace and directly replacing definitions like compact_str = { workspace = true } in the companion libraries with the actual dependency definitions from the workspace."

[xiaoniaoyouhuajiang]

You can try it by reinstalling it now.Feel free to let me know if encounter any problem.
@zavakid

[zavakid]

@xiaoniaoyouhuajiang Sorry, it still doesn't work. I forgot to mention that I have dependencies with specified paths, depending on other crates in the workspace, as below:

[dependencies]
serde = { version = "1", features = ["derive"] }
serde_json = "1"
bitflags = { workspace = true }
compact_str = { workspace = true }

# here, dependency other create
other_crate = { path = "crates/other_crate" }

It seems that the workspace deserves serious consideration.

[zavakid]

BTW, I couldn't find v0.1.4 in https://pypi.org/pypi/ferrumpy/json, it's still v0.1.3

[xiaoniaoyouhuajiang]

@zavakid Thanks for the feedback. I've updated the dependency conversion method and confirmed that the files on PyPI have been updated

[zavakid]

@xiaoniaoyouhuajiang Still not working, error message as follows:

error: Failed to create REPL: Failed to create REPL session: Failed to create REPL session: Could not find ferrumpy-repl-worker binary. Expected locations:
- FERRUMPY_REPL_WORKER environment variable
- Same directory as ferrumpy module (site-packages/ferrumpy/)
- System PATH
- ./target/{release,debug}/ (development)

Hint: Set FERRUMPY_REPL_WORKER=/path/to/ferrumpy-repl-worker for manual override.

I've uploaded a test project at https://github.com/zavakid/ferrumpy-demo , the above issue can be reproduced when debugging crates/foo

[xiaoniaoyouhuajiang]

I cloned your demo project and reproduced the issue. There are actually two problems: one is the workspace support (which has been completed in v0.1.5), and the other is that the types in compact_str cannot be deserialized. The latter cannot be directly solved by ferrumpy (this is an inherent limitation, see the README). Therefore, you need to modify the dependency configuration to: compact_str = { version = "0.9", features = ["serde"] }

After modifying, the ferrumpy repl can be established, @zavakid

[zavakid]

When I reinstalled, I encountered an issue with the export path update, here I submit a PR for the installation script, see #3

[zavakid]

I cloned your demo project and reproduced the issue. There are actually two problems: one is the workspace support (which has been completed in v0.1.5), and the other is that the types in compact_str cannot be deserialized. The latter cannot be directly solved by ferrumpy (this is an inherent limitation, see the README). Therefore, you need to modify the dependency configuration to: compact_str = { version = "0.9", features = ["serde"] }

After modifying, the ferrumpy repl can be established, @zavakid

👍🏻 It works , but it can't print the value of the worker variable , in the demo project: https://github.com/zavakid/ferrumpy-demo/blob/main/crates/foo/src/main.rs