Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commit a40a746030e78682f481bd2a010215d49045fe79 cause program crash #2196

Closed
yingziwu opened this issue Feb 23, 2025 · 3 comments · Fixed by #2197
Closed

commit a40a746030e78682f481bd2a010215d49045fe79 cause program crash #2196

yingziwu opened this issue Feb 23, 2025 · 3 comments · Fixed by #2197

Comments

@yingziwu
Copy link

yingziwu commented Feb 23, 2025 •
edited
Loading

Describe the bug

After upgrade goldendict-ng-git to 25.04.0.r5917.a40a7460-1 and late version, the program crash and can't start.

To Reproduce

  1. Install goldendict-ng-git-25.04.0.r5916.b72c0cad and it work normally.
  2. Upgrade to goldendict-ng-git-25.04.0.r5917.a40a7460 and it crash.

PS:
I build goldendict-ng-git with archlinuxcn PKGBUILD and specify commit with commit fragment.

If you use archlinux, and you can install goldendict-ng-git from the following prebuilded packages
goldendict-ng-git-25.04.0.r591.zip

Expected behavior
The goldendict-ng work normally.

OS and software versions

Qt 6.8.2 GCC 14.2.1 20250207
arch linux 6.13.4-zen1-1-zen x86_64-little_endian-lp64
Flags: ZIM EPWING OPENCC

Additional context

$ pacman -Qi goldendict-ng-git
Name            : goldendict-ng-git
Version         : 25.04.0.r5917.a40a7460-1
Description     : The next generation GoldenDict (Supports Qt WebEngine & Qt6).
Architecture    : x86_64
URL             : https://github.com/xiaoyifang/goldendict-ng
Licenses        : GPL3
Groups          : None
Provides        : goldendict
Depends On      : hunspell  libvorbis  libxtst  lzo  zlib  xz  libeb  tomlplusplus  fmt  opencc  xapian-core  libzim  qt6-base  qt6-svg  qt6-multimedia  qt6-webengine  qt6-speech  qt6-5compat
Optional Deps   : None
Required By     : None
Optional For    : None
Conflicts With  : goldendict  goldendict-git  goldendict-svn  goldendict-git-opt
Replaces        : goldendict-svn  goldendict-git-opt  goldendict-webengine-git
Installed Size  : 9.39 MiB
Packager        : BGME <i@bgme.me>
Build Date      : Sun 23 Feb 2025 03:35:25 PM CST
Install Date    : Sun 23 Feb 2025 04:04:22 PM CST
Install Reason  : Explicitly installed
Install Script  : No
Validated By    : None
$ rm -rf ~/.goldendict ~/.cache/goldendict ~/.config/goldendict

$ goldendict 
Failed to load:  "" ""  from  "/usr/share/goldendict/locale"
qt.multimedia.ffmpeg: Using Qt multimedia with FFmpeg version n7.1 GPL version 3 or later
qt.multimedia.ffmpeg: Available HW decoding frameworks:
qt.multimedia.ffmpeg:      vaapi
qt.multimedia.ffmpeg:      vdpau
qt.multimedia.ffmpeg:      vulkan
qt.multimedia.ffmpeg: Available HW encoding frameworks:
qt.multimedia.ffmpeg:      vaapi
qt.multimedia.ffmpeg:      vdpau
qt.multimedia.ffmpeg:      vulkan
No favorites file found
[1]    56851 segmentation fault (core dumped)  goldendict
$ coredumpctl debug 56851
           PID: 56851 (goldendict)
           UID: 1000 (arch)
           GID: 1000 (arch)
        Signal: 11 (SEGV)
     Timestamp: Sun 2025-02-23 16:26:18 CST (31s ago)
  Command Line: goldendict
    Executable: /usr/bin/goldendict
 Control Group: /user.slice/user-1000.slice/user@1000.service/app.slice/kitty-2324-6.scope
          Unit: user@1000.service
     User Unit: kitty-2324-6.scope
         Slice: user-1000.slice
     Owner UID: 1000 (arch)
       Boot ID: c509503225c648718f5860942c9a7256
    Machine ID: [redacted]
      Hostname: [redacted]
       Storage: /var/lib/systemd/coredump/core.goldendict.1000.c509503225c648718f5860942c9a7256.56851.1740299178000000.zst (present)
  Size on Disk: 7.7M
       Message: Process 56851 (goldendict) of user 1000 dumped core.
                
                Stack trace of thread 56851:
                #0  0x0000588bf5f43c63 n/a (n/a + 0x0)
                #1  0x0000588bf600be98 n/a (n/a + 0x0)
                #2  0x0000588bf5e56f51 n/a (n/a + 0x0)
                #3  0x00007e0120c35488 n/a (n/a + 0x0)
                #4  0x00007e0120c3554c n/a (n/a + 0x0)
                #5  0x0000588bf5e5b1c5 n/a (n/a + 0x0)
                ELF object binary architecture: AMD x86-64

[Thread debugging using libthread_db enabled]                                                                                                                                                                       
Using host libthread_db library "/usr/lib/libthread_db.so.1".
Core was generated by `/usr/bin/goldendict'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::size (this=<optimized out>, this=<optimized out>) at /usr/include/c++/14.2.1/bits/basic_string.h:1076
1076	     size() const _GLIBCXX_NOEXCEPT
[Current thread is 1 (Thread 0x7e010ba8b540 (LWP 56851))]
(gdb) bt
#0  std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::size (this=<optimized out>, this=<optimized out>) at /usr/include/c++/14.2.1/bits/basic_string.h:1076
#1  loadDictionaries (parent=0x7ffd16288140, cfg=..., dictionaries=..., dictNetMgr=..., doDeferredInit_=<optimized out>) at /usr/src/debug/goldendict-ng-git/goldendict-ng-git/src/dict/loaddictionaries.cc:233
#2  0x0000588bf600be98 in MainWindow::makeDictionaries (this=0x7ffd16288140) at /usr/src/debug/goldendict-ng-git/goldendict-ng-git/src/ui/mainwindow.cc:1588
#3  MainWindow::MainWindow (this=<optimized out>, cfg_=..., this=<optimized out>, cfg_=...) at /usr/src/debug/goldendict-ng-git/goldendict-ng-git/src/ui/mainwindow.cc:753
#4  0x0000588bf5e56f51 in main (argc=<optimized out>, argv=<optimized out>) at /usr/src/debug/goldendict-ng-git/goldendict-ng-git/src/main.cc:510
@xiaoyifang xiaoyifang mentioned this issue Feb 23, 2025
Merged
@xiaoyifang
Copy link
Owner

thanks for reporting ,can you help to test this #2197

@yingziwu
Copy link
Author

The pr #2197 work normally on my machine.

@xiaoyifang
Copy link
Owner

thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: temporary string cause crash xiaoyifang/goldendict-ng
2 participants
@xiaoyifang @yingziwu