Consistency issues and bug fixes

[nickgirga]

As you may have seen in my pull request, I was translating this app to full English, and I ran across a few bugs and consistency issues. I would create pull requests with these commits, but they are so tangled in my git tree along with my translations (which I assume you don't want), that I think the best I can do with this situation is inform you of the issues through GitHub's issue tracker.

pepiwiredir

The first thing I noticed is an unknown reference to pepiwiredir on line 8. For starters, it doesn't exist. It's not a command. It's not an alias. And it isn't preceded by a $, so my first assumption was that it was not a variable. But it looks very, very similar to $pipewiredir and logically, it would make sense if that's what is supposed to be there. So, in my script, I updated it to say test -d $pipewiredir || mkdir -p $pipewiredir, rather than test -d pepiwiredir || mkdir -p $pipewiredir. That being said, mkdir -p <path> actually only does something if the desired folder doesn't exist, so it isn't really necessary to check. You can just run your mkdir -p <path> commands at the start of the script every time and call it a day. It won't print any errors or anything. It just won't make new folders if they already exist.

Inconsistency

The second thing I noticed is the inconsistency in labeling. For example, sometimes it says "Samplerate", sometimes it says "Sample Rate". It should always appear the same. At the very least be consistent with all of the other labels. For example, in my fork, I changed all visible instances of "Sample Rate" to "Sample Rate" and all visible instances of "Frame Period" to "Frame Period". This was a minor irritant, but it highlighted something else I noticed that maybe only happens on specific machines in specific environments.

Broken display (extra numbers)

As I was fixing the label consistency issues, I realized that the value of the frame buffer, pulled from the config, has 2 values, even after filtering "limit" out: "default.clock.quantum" and "default.clock.quantum-floor". My solution to this was to pipe the output into an addition grep filter on line 24: atualFrames=$(grep 'default.clock.quantum' $pipewireconf | grep -v limit | grep -i floor | awk '{print $3}'). This solved my problem and got rid of the extra number on the display.