set default validator when nil (#92)

* set default validator when nil

* updated changelog

* added unit tests

* prep for release

Author: kristinapathak

CHANGELOG.md

@@ -5,7 +5,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+
+## [v0.3.5]
 - Changed errorEncoder to log errors. [#90](https://github.com/xmidt-org/ancla/pull/90)
+- Fixed webhook request decoder panic; added default validator when none given. [#92](https://github.com/xmidt-org/ancla/pull/92)
 
 ## [v0.3.4]
 - Added more details to some validation errors. [#91](https://github.com/xmidt-org/ancla/pull/91)
@@ -84,7 +87,8 @@ internalWebhooks. [#80](https://github.com/xmidt-org/ancla/pull/80)
 ## [v0.1.0]
 - Initial release
 
-[Unreleased]: https://github.com/xmidt-org/ancla/compare/v0.3.4...HEAD
+[Unreleased]: https://github.com/xmidt-org/ancla/compare/v0.3.5...HEAD
+[v0.3.5]: https://github.com/xmidt-org/ancla/compare/0.3.4...v0.3.5
 [v0.3.4]: https://github.com/xmidt-org/ancla/compare/0.3.3...v0.3.4
 [v0.3.3]: https://github.com/xmidt-org/ancla/compare/0.3.2...v0.3.3
 [v0.3.2]: https://github.com/xmidt-org/ancla/compare/0.3.1...v0.3.2

transport.go

@@ -97,6 +97,11 @@ func addWebhookRequestDecoder(config transportConfig) kithttp.DecodeRequestFunc
 		config.basicPartnerIDsHeader = DefaultBasicPartnerIDsHeader
 	}
 
+	// if no validators are given, we accept anything.
+	if config.v == nil {
+		config.v = AlwaysValid()
+	}
+
 	return func(c context.Context, r *http.Request) (request interface{}, err error) {
 		requestPayload, err := ioutil.ReadAll(r.Body)
 		if err != nil {

transport_test.go

@@ -179,6 +179,12 @@ func TestAddWebhookRequestDecoder(t *testing.T) {
 			Validator:              Validators{},
 			Auth:                   "jwt",
 		},
+		{
+			Description:            "No validator provided",
+			InputPayload:           addWebhookDecoderInput(),
+			ExpectedDecodedRequest: addWebhookDecoderOutput(true),
+			Auth:                   "jwt",
+		},
 		{
 			Description:            "Do not check PartnerIDs",
 			InputPayload:           addWebhookDecoderInput(),

webhookValidator.go

@@ -71,6 +71,13 @@ func (vf ValidatorFunc) Validate(w Webhook) error {
 	return vf(w)
 }
 
+// AlwaysValid doesn't check anything in the webhook and never returns an error.
+func AlwaysValid() ValidatorFunc {
+	return func(w Webhook) error {
+		return nil
+	}
+}
+
 // CheckEvents makes sure there is at least one value in Events and ensures that
 // all values should parse into regex.
 func CheckEvents() ValidatorFunc {

webhookValidator_test.go

@@ -34,6 +34,11 @@ var (
 	negativeThreeDuration = -3 * time.Minute
 )
 
+func TestAlwaysValid(t *testing.T) {
+	err := AlwaysValid()(Webhook{})
+	assert.NoError(t, err)
+}
+
 func TestCheckEvents(t *testing.T) {
 	tcs := []struct {
 		desc        string