Skip to content

Commit 4a08826

Browse files
committed
fixed panic due to no logger
1 parent bc7407e commit 4a08826

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

internal/sink/sink.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,11 +68,13 @@ func NewSink(c Config, logger *zap.Logger, listener ancla.Register) Sink {
6868
id: l.Registration.CanonicalName,
6969
brokerAddr: k.BootstrapServers,
7070
topic: "quickstart-events",
71+
logger: logger,
7172
}
7273

7374
config := sarama.NewConfig()
7475
//TODO: this is basic set up for now - will need to add more options to config
7576
//once we know what we are allowing users to send
77+
7678
config.Producer.Return.Successes = true
7779
config.Producer.RequiredAcks = sarama.WaitForAll
7880
config.Producer.Retry.Max = c.DeliveryRetries //should we be using retryhint for this?
@@ -344,9 +346,9 @@ func (k *Kafka) send(secret string, acceptType string, msg *wrp.Message) error {
344346

345347
// Send the message to Kafka
346348
partition, offset, err := k.producer.SendMessage(kafkaMsg)
349+
defer k.producer.Close()
347350
if err != nil {
348351
k.logger.Error("Failed to send message to Kafka", zap.Error(err))
349-
k.producer.Close()
350352
return err
351353
}
352354

@@ -356,7 +358,6 @@ func (k *Kafka) send(secret string, acceptType string, msg *wrp.Message) error {
356358
zap.Int32("Partition", partition),
357359
zap.Int64("Offset", offset),
358360
)
359-
k.producer.Close()
360361

361362
return nil
362363

0 commit comments

Comments
 (0)