Skip to content

Commit 80b03e8

Browse files
Bumped codex (#93)
1 parent 6096e99 commit 80b03e8

File tree

4 files changed

+24
-18
lines changed

4 files changed

+24
-18
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ module github.com/Comcast/codex-svalinn
33
go 1.12
44

55
require (
6-
github.com/Comcast/codex v0.6.0
6+
github.com/Comcast/codex v0.7.0
77
github.com/Comcast/webpa-common v1.0.1
88
github.com/Comcast/wrp-go v1.0.1-0.20190425181536-16cc54c2efd1
99
github.com/InVisionApp/go-health v2.1.0+incompatible

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ cloud.google.com/go v0.26.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMT
33
github.com/Azure/go-ansiterm v0.0.0-20170929234023-d6e3b3328b78/go.mod h1:LmzpDX56iTiv29bbRTIsUNlaFfuhWRQBWjQdVyAevI8=
44
github.com/BurntSushi/toml v0.3.1 h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=
55
github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU=
6-
github.com/Comcast/codex v0.6.0 h1:SvOCqyiFys6g31TWjMcUioapYtjjg2JI0VZL3Oe6XaQ=
7-
github.com/Comcast/codex v0.6.0/go.mod h1:0EfKNJTGyayQae7ciafhglQtpGiYD87GaU8nBuLPR1A=
6+
github.com/Comcast/codex v0.7.0 h1:/N16BJKncmPsECspBJyxH2z3Y4isgdMI3ti0IGofsJM=
7+
github.com/Comcast/codex v0.7.0/go.mod h1:0EfKNJTGyayQae7ciafhglQtpGiYD87GaU8nBuLPR1A=
88
github.com/Comcast/webpa-common v1.0.0 h1:rItnLnh/3nVo+l3+O35pUAeMXaSHNSgyaU7kY6rGBBc=
99
github.com/Comcast/webpa-common v1.0.0/go.mod h1:XSu1nN06grod4RD/3WRYdeMMKDXBpeosZgIoNcmYsus=
1010
github.com/Comcast/webpa-common v1.0.1 h1:HMM8HFgI//umwSiYnCd8MJDGSXUVMqjyfqzYTAbeuUk=

main.go

Lines changed: 19 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@ import (
2424
_ "net/http/pprof"
2525
"sync"
2626

27+
"github.com/Comcast/codex/db/retry"
28+
29+
"github.com/Comcast/codex/db/postgresql"
30+
2731
"github.com/Comcast/codex-svalinn/requestParser"
2832
"github.com/Comcast/codex/db/batchInserter"
2933

@@ -68,7 +72,7 @@ type SvalinnConfig struct {
6872
Webhook WebhookConfig
6973
RequestParser requestParser.Config
7074
BatchInserter batchInserter.Config
71-
Db db.Config
75+
Db postgresql.Config
7276
InsertRetries RetryConfig
7377
BlacklistInterval time.Duration
7478
}
@@ -88,7 +92,7 @@ type Svalinn struct {
8892
}
8993

9094
type database struct {
91-
dbConn *db.Connection
95+
dbClose func() error
9296
blacklistStop chan struct{}
9397
blacklistRefresher blacklist.List
9498
inserter db.Inserter
@@ -105,7 +109,7 @@ func svalinn(arguments []string) {
105109

106110
var (
107111
f, v = pflag.NewFlagSet(applicationName, pflag.ContinueOnError), viper.New()
108-
logger, metricsRegistry, codex, err = server.Initialize(applicationName, arguments, f, v, secure.Metrics, db.Metrics, requestParser.Metrics, batchInserter.Metrics)
112+
logger, metricsRegistry, codex, err = server.Initialize(applicationName, arguments, f, v, secure.Metrics, postgresql.Metrics, dbretry.Metrics, requestParser.Metrics, batchInserter.Metrics)
109113
)
110114

111115
if parseErr, done := printVersion(f, arguments); done {
@@ -201,31 +205,32 @@ func exitIfError(logger log.Logger, err error) {
201205

202206
func setupDb(config *SvalinnConfig, logger log.Logger, metricsRegistry xmetrics.Registry) (database, error) {
203207
var (
204-
d database
205-
err error
208+
d database
206209
)
207210
d.health = health.New()
208211
d.health.Logger = healthlogger.NewHealthLogger(logger)
209212

210-
d.dbConn, err = db.CreateDbConnection(config.Db, metricsRegistry, d.health)
213+
dbConn, err := postgresql.CreateDbConnection(config.Db, metricsRegistry, d.health)
211214
if err != nil {
212215
return database{}, err
213216
}
214217

215-
d.inserter = db.CreateRetryInsertService(
216-
d.dbConn,
217-
db.WithRetries(config.InsertRetries.NumRetries),
218-
db.WithInterval(config.InsertRetries.Interval),
219-
db.WithIntervalMultiplier(config.InsertRetries.IntervalMult),
220-
db.WithMeasures(metricsRegistry),
218+
d.dbClose = dbConn.Close
219+
220+
d.inserter = dbretry.CreateRetryInsertService(
221+
dbConn,
222+
dbretry.WithRetries(config.InsertRetries.NumRetries),
223+
dbretry.WithInterval(config.InsertRetries.Interval),
224+
dbretry.WithIntervalMultiplier(config.InsertRetries.IntervalMult),
225+
dbretry.WithMeasures(metricsRegistry),
221226
)
222227

223228
d.blacklistStop = make(chan struct{}, 1)
224229
blacklistConfig := blacklist.RefresherConfig{
225230
Logger: logger,
226231
UpdateInterval: config.BlacklistInterval,
227232
}
228-
d.blacklistRefresher = blacklist.NewListRefresher(blacklistConfig, d.dbConn, d.blacklistStop)
233+
d.blacklistRefresher = blacklist.NewListRefresher(blacklistConfig, dbConn, d.blacklistStop)
229234
return d, nil
230235

231236
}
@@ -272,7 +277,7 @@ func waitUntilShutdown(logger log.Logger, s *Svalinn, database database) {
272277
s.waitGroup.Wait()
273278
s.requestParser.Stop()
274279
s.batchInserter.Stop()
275-
err = database.dbConn.Close()
280+
err = database.dbClose()
276281
if err != nil {
277282
logging.Error(logger, emperror.Context(err)...).Log(logging.MessageKey(), "closing database threads failed",
278283
logging.ErrorKey(), err.Error())

release_notes.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1-
1+
- Added deathdate check
2+
- Bumped codex

0 commit comments

Comments
 (0)