Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing release #113

Closed
thekid opened this issue May 18, 2024 · 3 comments
Closed

Routing release #113

thekid opened this issue May 18, 2024 · 3 comments

Comments

@thekid
Copy link
Member

thekid commented May 18, 2024

With PR #111 and #112, we have the following options for the next release:

Both into 4.2.0

Merge both pull requests into a feature release. There are theoretical small breaks in the routing PR, e.g. with /{id} which previously matched a path containing curly braces and the characters id, and now serves as a placeholder. The deprecated web.Routing would be removed in 5.0.0, which could be released pretty much right after.

Dispatch into 4.2.0, routing into 4.3.0

Create a feature release with dispatching and defer routing until the next feature release. This would allow to separate effects of these two features should it be necessary.

Dispatch into 4.2.0, routing into 5.0.0

Create a feature release with dispatching but defer routing until the next major release. This will allow xp-forge/frontend#48 to retain support for 4.X in contrast to the next option. To keep a transition period, the deprecated web.Routing would not be removed until 6.0.0.

Both into 5.0.0

Due to the small (but existant!) BC breaks roll both as a major release. As above, the deprecated web.Routing would not be removed until 6.0.0.

@thekid
Copy link
Member Author

thekid commented May 18, 2024

By re-adding web.Dispatch (and deprecating it at the same time!) we would further reduce the BC breaks. However, this class was always meant to be used (and consequently advertised as such, see below) behind Request::dispatch(), and never to be manually instantiated:

Return instances of this class from a handler before the response has been flushed, as follows:

function($req, $res) {
  return $req->dispatch('/home');
}

See https://github.com/xp-forge/web?tab=readme-ov-file#internal-redirects

@thekid
Copy link
Member Author

thekid commented May 18, 2024

With the last commit, we can now definitely roll #112 into 4.2.0.

@thekid
Copy link
Member Author

thekid commented May 20, 2024

👉 Decided to release dispatching as separate 4.2.0-RELEASE

@thekid thekid removed the question label May 20, 2024
@thekid thekid closed this as completed May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant