Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newly released Cython may be backward incompatible for an X-PSI installation #319

Closed
evertrol opened this issue Aug 2, 2023 · 1 comment · Fixed by #434
Closed

Newly released Cython may be backward incompatible for an X-PSI installation #319

evertrol opened this issue Aug 2, 2023 · 1 comment · Fixed by #434
Assignees
Labels
hackweek2024 Issues to be fixed during the 2024 Hack Week

Comments

@evertrol
Copy link
Contributor

evertrol commented Aug 2, 2023

Cython 3.0.0 has recently been released (July 17, 2023), and has likely backward incompatibilities with the Cython 0.2* series. Since X-PSI relies on Cython to be build afaik, this may cause build problems.

Ultimately, if there are build errors with Cython 3, it should be fixed here in the code that uses and builds Cython, so that X-PSI is forward-compatible and future-proof.

A temporary(!) work-around is to set stricter requirements for the Cython dependency in setup.py. So this line

        setup_requires = ['cython'],

may become

        setup_requires = ['cython ~= 0.23'],

(or whatever minimal Cython version works. 0.29 might be fine.)

To clarify, the compatible release specifier, ~= 0.23, is similar to >= 0.23, == 0.*. Which you could also use if you find that clearer.


Aside, something similar should be the case for the NumPy dependency. There should be a minimum version requirement, and a maximum version requirement, for any dependency.

@evertrol evertrol changed the title Newly released Cython may be backward incompatible for an X-PSI Newly released Cython may be backward incompatible for an X-PSI installation Aug 3, 2023
@sguillot sguillot linked a pull request Aug 17, 2023 that will close this issue
@thjsal thjsal removed a link to a pull request Aug 22, 2023
@thjsal
Copy link
Contributor

thjsal commented Aug 22, 2023

The temporary work-around to this was done in #322 . Work should still be done to make X-PSI work with Cython 3.

@thjsal thjsal added the hackweek2024 Issues to be fixed during the 2024 Hack Week label Dec 2, 2024
@thjsal thjsal self-assigned this Dec 2, 2024
@thjsal thjsal linked a pull request Dec 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hackweek2024 Issues to be fixed during the 2024 Hack Week
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants