Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated use of Numpy (np.float) in post-processing corner plot #344

Closed
MHoogkamer opened this issue Nov 8, 2023 · 2 comments · Fixed by #345
Closed

Deprecated use of Numpy (np.float) in post-processing corner plot #344

MHoogkamer opened this issue Nov 8, 2023 · 2 comments · Fixed by #345
Labels
postprocessing Issues or updates for postprocessing

Comments

@MHoogkamer
Copy link
Contributor

Using the PostProcessing.Cornerplot gives the following issue:

AttributeError: module 'numpy' has no attribute 'float'.
`np.float` was a deprecated alias for the builtin `float`. To avoid this error in existing code, use `float` by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use `np.float64` here.
The aliases was originally deprecated in NumPy 1.20;

Can be solved by changing _np.float into float in line 947 in _corner.py

Related to #336

@MHoogkamer MHoogkamer added the postprocessing Issues or updates for postprocessing label Nov 8, 2023
@thjsal
Copy link
Contributor

thjsal commented Nov 8, 2023

For curiosity, what NumPy version are you using?

And I guess it is the np_.float in line 949 in the current _corner.py of the main branch.

Would you like to fix it?

@MHoogkamer
Copy link
Contributor Author

I'm using NumPy 1.26

Yes! I made a pull request

@thjsal thjsal linked a pull request Nov 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
postprocessing Issues or updates for postprocessing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants