diff --git a/mongo/pytests/powertest.py b/mongo/pytests/powertest.py index eec89171..0e995582 100755 --- a/mongo/pytests/powertest.py +++ b/mongo/pytests/powertest.py @@ -359,7 +359,26 @@ def install_tarball(tarball, root_dir): ext = get_extension(tarball) if ext == ".tgz": with tarfile.open(tarball, "r:gz") as tar_handle: - tar_handle.extractall(path=root_dir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar_handle, path=root_dir) output = "Unzipped {} to {}: {}".format(tarball, root_dir, tar_handle.getnames()) ret = 0 elif ext == ".zip":