Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade to async-profiler 2 #68

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: upgrade to async-profiler 2 #68

wants to merge 1 commit into from

Conversation

loicmathieu
Copy link
Contributor

@loicmathieu loicmathieu commented Oct 19, 2021 •
edited
Loading

Fixes #62

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@loicmathieu
Copy link
Contributor Author

@edeNFed I try to update to async profiler 2 using the released artifact but I don't know exactly how to test it.
I successfully build the images and the different cli but I don't know how to package them as a kubectl plugin, or at least test them in another way.

@BasselAshi
Copy link

Can you share how you compiled the code? I used go build cli/main.go but ended up getting stuck with Launching profiler ... when using the tool.

@loicmathieu
Copy link
Contributor Author

Hi @BasselAshi I use go build too to compile the code but as said I have no idea how to test it so I didn't run it.

@edeNFed
Copy link
Contributor

edeNFed commented Feb 4, 2022

Hi @loicmathieu You can test this by using the --image flag.
Simply upload your custom image to some registry and then invoke your compiled cli with:
./kubectl-flame --lang java <pod-name> -t 10s --image <image-name>

@loicmathieu
Copy link
Contributor Author

Thanks @edeNFed I'll have a look next week

@pvorb
Copy link

pvorb commented Jun 9, 2022

@loicmathieu Is there any progress so far?

@loicmathieu
Copy link
Contributor Author

@pvorb no, I didn't find the time to work on it yet.

pvorb
pvorb reviewed Sep 2, 2022
View reviewed changes
agent/docker/jvm/Dockerfile.alpine
RUN apk add build-base git linux-headers
RUN git clone https://github.com/edeNFed/async-profiler.git
RUN cd async-profiler && make
RUN apk add build-base linux-headers curl
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For unpacking the tar.gz file, the alpine tar package is needed because the existing tar command from busybox doesn't support all necessary features.

Suggested change
RUN apk add build-base linux-headers curl
RUN apk add build-base linux-headers curl tar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvorb pvorb pvorb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to async-profiler 2
4 participants
@loicmathieu @BasselAshi @edeNFed @pvorb