Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Select Mode, only change input once when changing values #1116

Open
CarlosFdez opened this issue Sep 6, 2022 · 2 comments
Open

In Select Mode, only change input once when changing values #1116

CarlosFdez opened this issue Sep 6, 2022 · 2 comments
Labels

Comments

@CarlosFdez
Copy link

CarlosFdez commented Sep 6, 2022

First of all, big thanks for working on this. This library so far has been very helpful for the Pathfinder 2e system for Foundry, and for lists of validated traits it has been much better than the way we've been doing it before.

So currently, for tagify controls in select mode, it seems that whenever you change the selected value when a value has already been selected, it changes the associated input twice, once to clear the data, and again to set the new data. It would be really nice if the input was changed only once to the final result, that way the input change event fires once for the new result. Right now a DB update and re-render is tied to that on change event in what I'm working on, swallowing the second update whole.

@yairEO
Copy link
Owner

yairEO commented Sep 7, 2022

Thanks Carlos! I will look into it

@stwlam
Copy link

stwlam commented Dec 30, 2022

Is this really an "enhancement" request rather than a bug report? Making a selection once causes two change events to fire.

@yairEO yairEO added Bug and removed Enhancement labels Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants