Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi level grouping #4

Open
SimJoSt opened this issue Jul 30, 2019 · 6 comments
Open

Multi level grouping #4

SimJoSt opened this issue Jul 30, 2019 · 6 comments

Comments

@SimJoSt
Copy link

SimJoSt commented Jul 30, 2019

We use multiple prefixes in our Slack channel names. It would be great to group the second level prefixes as well.

p-customer-project is a often used scheme in our company.

@yamadashy
Copy link
Owner

Hi!
thank you for reporting.

I want it too.
Work in progress 😄

@timwredwards
Copy link

+1

@SimJoSt
Copy link
Author

SimJoSt commented Jun 11, 2023

Great to hear. Just stumbled upon this again. Is there a timeline for the development?
Unfortunately, I cannot contribute with a PR.

@ryooo
Copy link

ryooo commented Dec 1, 2024

Hi.
Thank you for the great extension.

My fork now supports multi level grouping up to level 4.
I haven't written any tests and the code isn't refactored, but if you'd like, you might be able to use it if you build it.

https://github.com/ryooo/slack-channels-grouping

@yamadashy
Copy link
Owner

@ryooo
Thank you so much for your contribution! Don't worry about the tests - I can add those later. I'm just grateful for any help with the implementation.

I've tried it locally and it works great!

image

If you could create a draft PR, our CI will automatically build packages for each vendor, making it easier to verify changes during development.

One small suggestion though - I think it would be nice to have this feature configurable through a popup when clicking the extension icon (similar to how Dark Reader works). We can keep it enabled by default since it's a useful improvement for most users.

I can handle this configuration UI part after merging your changes.

@ryooo
Copy link

ryooo commented Dec 1, 2024

@yamadashy
Thank you for your wonderful suggestion!
It would be nice to have settings.
I will send PR in the draft, so I would appreciate it if you could modify it as you like.

I am always grateful.
Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants