Skip to content

Commit 7812468

Browse files
committed
openapi2jsonschema.py now correctly fails if no FILE is passed
1 parent 2e50b79 commit 7812468

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

scripts/acceptance.bats

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,3 +72,10 @@ setup() {
7272
run diff prometheus_v1.json ./fixtures/prometheus_v1-denyRootAdditionalProperties.json
7373
[ "$status" -eq 0 ]
7474
}
75+
76+
@test "Should output an error if no file is passed" {
77+
run ./openapi2jsonschema.py
78+
[ "$status" -eq 1 ]
79+
[ "${lines[0]}" == 'Missing FILE parameter.' ]
80+
[ "${lines[1]}" == 'Usage: ./openapi2jsonschema.py [FILE]' ]
81+
}

scripts/openapi2jsonschema.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,8 @@ def construct_value(load, node):
122122

123123

124124
if __name__ == "__main__":
125-
if len(sys.argv) == 0:
126-
print("missing file")
125+
if len(sys.argv) < 2:
126+
print('Missing FILE parameter.\nUsage: %s [FILE]' % sys.argv[0])
127127
exit(1)
128128

129129
for crdFile in sys.argv[1:]:

0 commit comments

Comments
 (0)