-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Region of interest feature does not work for non-square aspect ratios(!) #179
Comments
Has there been a solution for this? I'm experiencing this as well. If I pull the phone really far away so the QR code is teeny tiny, it scans. Anything other than that will not work. My scale ends up being much smaller than what @xc212 experienced, using an iPhoneX. |
Also, @xc212 if you don't use a rectOfInterest, it should scan fine at any size, which is my workaround for now. It seems the interest rectangle is done as a percentage of the screen, so getting a square might not be possible anyhow. This seems to be an issue with certain phone resolutions as well, so it's possible the drawn interest area and the actual area of the image being checked differ. |
I'm having this same problem. If I don't use |
The underlying seems to be that the This is why a square area of interest works: the 'displayed' rectangle matches the detection region. |
Expected behavior:
Found behavior:
Steps to reproduce:
^ this is the maximum scale I could get the QR code to scan with, starting from a close zoom
Tested on iOS 13 with iPhone X
The text was updated successfully, but these errors were encountered: