Skip to content

Commit 84d223a

Browse files
authored
🐛 remove duplicate field name in body (#17)
1 parent 2285d01 commit 84d223a

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

codegen/parser/endpoints/endpoint.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,10 @@ def header_params(self) -> List[Parameter]:
5252
def cookie_params(self) -> List[Parameter]:
5353
return [param for param in self.parameters if param.param_in == "cookie"]
5454

55+
@property
56+
def param_names(self) -> List[str]:
57+
return [param.prop_name for param in self.parameters]
58+
5559
def get_imports(self) -> Set[str]:
5660
imports = set()
5761
for param in self.parameters:

codegen/templates/client/_param.py.jinja

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,11 @@
2222
{% endfor %}
2323
{% endmacro %}
2424

25-
{% macro body_params(model) %}
25+
{% macro body_params(model, exclude=[]) %}
2626
{% for prop in model.properties %}
27+
{% if prop.prop_name not in exclude %}
2728
{{ prop.get_param_defination() }},
29+
{% endif %}
2830
{% endfor %}
2931
{% endmacro %}
3032

@@ -44,7 +46,7 @@
4446
{{ cookie_params(endpoint) }}
4547
*,
4648
data: Unset = UNSET,
47-
{{ body_params(model) }}
49+
{{ body_params(model, endpoint.param_names) }}
4850
{% endmacro %}
4951

5052
{% macro endpoint_params(endpoint, model) %}

githubkit/rest/actions.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2192,7 +2192,6 @@ def update_org_variable(
21922192
name: str,
21932193
*,
21942194
data: Unset = UNSET,
2195-
name: Union[Unset, str] = UNSET,
21962195
value: Union[Unset, str] = UNSET,
21972196
visibility: Union[Unset, Literal["all", "private", "selected"]] = UNSET,
21982197
selected_repository_ids: Union[Unset, List[int]] = UNSET,
@@ -2235,7 +2234,6 @@ async def async_update_org_variable(
22352234
name: str,
22362235
*,
22372236
data: Unset = UNSET,
2238-
name: Union[Unset, str] = UNSET,
22392237
value: Union[Unset, str] = UNSET,
22402238
visibility: Union[Unset, Literal["all", "private", "selected"]] = UNSET,
22412239
selected_repository_ids: Union[Unset, List[int]] = UNSET,
@@ -5570,7 +5568,6 @@ def update_repo_variable(
55705568
name: str,
55715569
*,
55725570
data: Unset = UNSET,
5573-
name: Union[Unset, str] = UNSET,
55745571
value: Union[Unset, str] = UNSET,
55755572
) -> "Response":
55765573
...
@@ -5618,7 +5615,6 @@ async def async_update_repo_variable(
56185615
name: str,
56195616
*,
56205617
data: Unset = UNSET,
5621-
name: Union[Unset, str] = UNSET,
56225618
value: Union[Unset, str] = UNSET,
56235619
) -> "Response":
56245620
...
@@ -6468,7 +6464,6 @@ def update_environment_variable(
64686464
environment_name: str,
64696465
*,
64706466
data: Unset = UNSET,
6471-
name: Union[Unset, str] = UNSET,
64726467
value: Union[Unset, str] = UNSET,
64736468
) -> "Response":
64746469
...
@@ -6522,7 +6517,6 @@ async def async_update_environment_variable(
65226517
environment_name: str,
65236518
*,
65246519
data: Unset = UNSET,
6525-
name: Union[Unset, str] = UNSET,
65266520
value: Union[Unset, str] = UNSET,
65276521
) -> "Response":
65286522
...

0 commit comments

Comments
 (0)