Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrapper: don't restart healthy tablets #9369

Closed
snaury opened this issue Sep 17, 2024 · 1 comment
Closed

Bootstrapper: don't restart healthy tablets #9369

snaury opened this issue Sep 17, 2024 · 1 comment
Assignees

Comments

@snaury
Copy link
Member

snaury commented Sep 17, 2024

We have a problem with large clusters, where a restart of some nodes causes an unnecessary restart of system tablets. The reason is that it takes a lot of time to fully connect to the rest of the cluster, and bootstrapper often fails to connect to siblings. This makes it decide to start the tablet locally, which succeeds in displacing a perfectly healthy tablet from state storage.

We need to add an additional step that checks for an existing tablet:

  1. We need to wait until state storage works and has a quorum. It doesn't make sense to boot a tablet without a working state storage.
  2. State storage must have a consistent leader address (tablet will stop when it's inconsistent anyway). We need to connect to that (it may be outdated), and when it succeeds we need to wait until it stops/disconnects and repeat.
  3. Only when we are fairly certain that state storage is healthy, but current leader is unreachable, should we initiate a new voting round and restart the tablet.
@snaury snaury self-assigned this Sep 17, 2024
@snaury
Copy link
Member Author

snaury commented Sep 17, 2024

Feature request from @the-ancient-1: ability to sticky force some node to keep running the tablet unless it's unavailable. We decided it could be possible to skip state storage / pipe checking and start a round where a special non-random value (guaranteed winner) is used. When multiple nodes have selected the same random value then the minimum node id should be a winner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant