Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression] A couple of issues have been closed while the puzzles are still in place #379

Open
php-coder opened this issue Sep 5, 2022 · 6 comments

Comments

@php-coder
Copy link

The following issues have been mistakenly closed by @0pdd while the puzzles are still in place:

Here are these comments:

$ git grep -2 '@todo #1057 SeriesSaleImportForm: wait until setState() finishes'
src/main/frontend/src/components/SeriesSaleImportForm.js-               event.preventDefault();
src/main/frontend/src/components/SeriesSaleImportForm.js-
src/main/frontend/src/components/SeriesSaleImportForm.js:               // @todo #1057 SeriesSaleImportForm: wait until setState() finishes
src/main/frontend/src/components/SeriesSaleImportForm.js-               // (see https://reactjs.org/docs/react-component.html#setstate)
src/main/frontend/src/components/SeriesSaleImportForm.js-               this.setState({

$ git grep -2 '@todo #1448 AddSimilarSeriesForm.similarSeriesId: remove deprecated member'
src/main/java/ru/mystamps/web/feature/series/AddSimilarSeriesForm.java- // @todo #1280 AddSimilarSeriesForm: add integration test for mandatory similarSeriesId
src/main/java/ru/mystamps/web/feature/series/AddSimilarSeriesForm.java- // @todo #1280 AddSimilarSeriesForm: similarSeriesId must exist
src/main/java/ru/mystamps/web/feature/series/AddSimilarSeriesForm.java: // @todo #1448 AddSimilarSeriesForm.similarSeriesId: remove deprecated member
src/main/java/ru/mystamps/web/feature/series/AddSimilarSeriesForm.java- //
src/main/java/ru/mystamps/web/feature/series/AddSimilarSeriesForm.java- // NOTE: similarSeriesId is deprecated and exist only for backward compatibility

$ git grep -2 '@todo #1054 Extract list of exclusions to a common profile'
src/main/resources/application-postgres.properties-app.use-cdn: false
src/main/resources/application-postgres.properties-
src/main/resources/application-postgres.properties:# @todo #1054 Extract list of exclusions to a common profile
src/main/resources/application-postgres.properties-#
src/main/resources/application-postgres.properties-# Full list of autoconfiguration classes:

It seems like a regression in pdd but could be 0pdd bug as well.

@0crat 0crat added the 0crat/new label Sep 5, 2022
@php-coder php-coder changed the title A couple of issues have been closed while the puzzles are still in place [regression] A couple of issues have been closed while the puzzles are still in place Sep 5, 2022
@php-coder
Copy link
Author

This might be related to #366 as 3 closed issues had duplicates that were created because of the bug.

@php-coder
Copy link
Author

Ping! The bug is still here! It have just created yet another one issue for my comment -- php-coder/mystamps#1594

@php-coder
Copy link
Author

@yegor256 Could you, please, look at it?

0pdd become less useful because of that and I've started to think to get rid of it because I only see regressions and I don't see that they are fixed quickly (or at all).

:-(

@php-coder
Copy link
Author

Ping! The bug is still here! It have just created yet another one issue for my comment -- php-coder/mystamps#1594

Ok, this is another issue actually -- pdd created a duplicate because it has a bug -- it takes 3 lines into account while it should use only the first one.

@yegor256
Copy link
Owner

@php-coder can you please submit a ticket into cqfn/pdd repository about this problem: "it takes 3 lines into account while it should use only the first one."

@pnatashap
Copy link
Contributor

@php-coder do your agree with this new issue in pdd? cqfn/pdd#234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants