Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing EBMLReader? #4

Open
yell0wd0g opened this issue May 17, 2017 · 3 comments
Open

missing EBMLReader? #4

yell0wd0g opened this issue May 17, 2017 · 3 comments

Comments

@yell0wd0g
Copy link
Owner

yell0wd0g commented May 17, 2017

I'm missing the EBMLReader in the ebml package (it's not in ebml.tools either) at line
[https://github.com/yellowdoge/demos/blob/master/mediarecorder/demo.js#L26]

can you help @legokichi pretty pleeeease?

Screen_Shot_2017_05_17_at_4_27_44_PM
free picture hosting websites

@yell0wd0g yell0wd0g changed the title missing EMLReader? missing EBMLReader? May 18, 2017
@yell0wd0g
Copy link
Owner Author

I must have done something terribly wrong, because after some small cleanup I managed to download a .webm file with duration -- but no seeking XD. Also, I'm not sure I'm not doing something silly/unnecessary/nonsense... I'm currently running sth like:

  const elements = new ebml.Decoder().decode(webmBuf);

  const correctedElements = ebml.tools.putRefinedMetaData(elements, clusterPtrs, lastDuration);

  const refined_buf = new ebml.Encoder().encode(correctedElements);

  return new Blob([refined_buf, webmBuf], {type: "video/webm"});

as can be seen in the function reconstructIndexOfArrayBuffer()...

@legokichi could you take a quick look and point me in the right direction? Thanks!

@legokichi
Copy link

EBMLReader is a very experimental code. Moreover, it has nothing to do with the EBML encoder / decoder. So official is not added to the package of ts-ebml.

However, it can be used as follows.

import EBMLReader from 'ts-ebml/lib/EBMLReader';

@legokichi
Copy link

currently EBML.tools.putRefinedMetaData API is changed.
I changed the reference to Cluster to add to Cues instead of adding it to SeekHead.
please see source code and example code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants