Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Solmate for ERC1155/ERC20/Others? #33

Open
devtooligan opened this issue Feb 24, 2022 · 0 comments
Open

Use Solmate for ERC1155/ERC20/Others? #33

devtooligan opened this issue Feb 24, 2022 · 0 comments

Comments

@devtooligan
Copy link
Contributor

One of the main reasons we wrote a lot of our own contracts instead of using the popular OpenZeppelin library is because OZ's contracts are bloated and not optimized; we wanted to have control over what goes into the contract without the bloat.

Solmate is a gas optimized, audited, set of contracts that we are considering using. We are already using their 1155 implementation with the fCash wrapper. We also discussed using the Solmate ERC20 contract as well.

We should decide if we definitely want to use either or both of these contracts as well as others. We should also decide if we want to import the contracts direct from Solmate, or use some sort of wrapper, or copy/paste the code into our repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant