Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove attribute sorting #234

Open
vjik opened this issue Jan 8, 2025 · 2 comments
Open

Remove attribute sorting #234

vjik opened this issue Jan 8, 2025 · 2 comments
Assignees
@FrankiFixx
Labels
severity:BC breaking Breaks backwards compatibility
Milestone
4.0

Comments

@vjik
Copy link
Member

vjik commented Jan 8, 2025

Based on #232

Sorting was done in first implementation of HTML helper: yiisoft/yii2@30d70be
@vjik vjik added the severity:BC breaking Breaks backwards compatibility label Jan 8, 2025
@vjik vjik added this to the 4.0 milestone Jan 8, 2025
@samdark
Copy link
Member

samdark commented Jan 9, 2025

It was not the case for Yii1: https://github.com/yiisoft/yii/blob/master/framework/web/helpers/CHtml.php#L2810

@FrankiFixx
Copy link
Contributor

I work on it

FrankiFixx pushed a commit to FrankiFixx/html that referenced this issue Jan 14, 2025
Fix yiisoft#234. Remove useless tags attributes sorting. Fix tests
a45c741
FrankiFixx pushed a commit to FrankiFixx/html that referenced this issue Jan 14, 2025
Fix yiisoft#234 all test pass
2c077f3
FrankiFixx pushed a commit to FrankiFixx/html that referenced this issue Jan 14, 2025
Fix yiisoft#234 add changelog
5dbeb8c
@vjik vjik mentioned this issue Jan 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrankiFixx FrankiFixx

Labels
severity:BC breaking Breaks backwards compatibility
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
3 participants
@samdark @vjik @FrankiFixx