Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new %TagClass%() instead of %TagClass%::tag() #243

Open
vjik opened this issue Mar 19, 2025 · 2 comments
Open

Use new %TagClass%() instead of %TagClass%::tag() #243

vjik opened this issue Mar 19, 2025 · 2 comments
Labels
good first issue Simple enough issue to start with. status:under discussion

Comments

@vjik
Copy link
Member

vjik commented Mar 19, 2025

With PHP 8.4 (new MyClass()->method() without parentheses) single static constructor has lost its meaning.

Suggestion for NormalTag, VoidTag and CustomTag:

  • make constructor public;
  • deprecate static constructor.
@xepozz xepozz added the good first issue Simple enough issue to start with. label Mar 20, 2025
@samdark
Copy link
Member

samdark commented Mar 20, 2025

How about consistency? Would it be the same for all other tags?

@vjik
Copy link
Member Author

vjik commented Mar 20, 2025

How about consistency? Would it be the same for all other tags?

All other tags extends NormalTag or VoidTag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Simple enough issue to start with. status:under discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samdark @vjik @xepozz