Skip to content

Commit 4460cf7

Browse files
authored
Remove unnecessary check in ContainerAttributeResolverFactory (#58)
1 parent 0429b31 commit 4460cf7

File tree

2 files changed

+3
-17
lines changed

2 files changed

+3
-17
lines changed

src/AttributeHandling/ResolverFactory/AttributeResolverFactoryInterface.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ interface AttributeResolverFactoryInterface
1313
/**
1414
* @throws AttributeResolverNonInstantiableException
1515
*/
16-
public function create(DataAttributeInterface|ParameterAttributeInterface $attribute): object;
16+
public function create(DataAttributeInterface|ParameterAttributeInterface $attribute): mixed;
1717
}

src/AttributeHandling/ResolverFactory/ContainerAttributeResolverFactory.php

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,12 @@
44

55
namespace Yiisoft\Hydrator\AttributeHandling\ResolverFactory;
66

7-
use LogicException;
87
use Psr\Container\ContainerExceptionInterface;
98
use Psr\Container\ContainerInterface;
109
use Yiisoft\Hydrator\Attribute\Data\DataAttributeInterface;
1110
use Yiisoft\Hydrator\AttributeHandling\Exception\AttributeResolverNonInstantiableException;
1211
use Yiisoft\Hydrator\Attribute\Parameter\ParameterAttributeInterface;
1312

14-
use function is_object;
1513
use function is_string;
1614

1715
final class ContainerAttributeResolverFactory implements AttributeResolverFactoryInterface
@@ -27,7 +25,7 @@ public function __construct(
2725
/**
2826
* @throws ContainerExceptionInterface
2927
*/
30-
public function create(DataAttributeInterface|ParameterAttributeInterface $attribute): object
28+
public function create(DataAttributeInterface|ParameterAttributeInterface $attribute): mixed
3129
{
3230
$resolver = $attribute->getResolver();
3331
if (!is_string($resolver)) {
@@ -43,18 +41,6 @@ public function create(DataAttributeInterface|ParameterAttributeInterface $attri
4341
);
4442
}
4543

46-
$result = $this->container->get($resolver);
47-
48-
if (!is_object($result)) {
49-
throw new LogicException(
50-
sprintf(
51-
'Resolver "%s" must be an object, "%s" given.',
52-
$resolver,
53-
get_debug_type($result),
54-
),
55-
);
56-
}
57-
58-
return $result;
44+
return $this->container->get($resolver);
5945
}
6046
}

0 commit comments

Comments
 (0)