Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation failures for side-traces immediately give up on this guard. #1560

Open
ptersilie opened this issue Jan 24, 2025 · 0 comments
Open
Assignees

Comments

@ptersilie
Copy link
Contributor

When a side-trace fails to compile in https://github.com/ykjit/yk/blob/master/ykrt/src/mt.rs#L370 we currently don't count the failures. Instead, the guard stays in GuardState::SideTracing and thus never tries to trace this guard again. Instead, we probably want a counter similar to normal traces before we give up on a guard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants