Skip to content

Commit d9df3a9

Browse files
authored
Avoid final classes for jobs but add final to methods (#31)
1 parent 1fd77b1 commit d9df3a9

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/batch/src/Job/AbstractJob.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ abstract class AbstractJob implements JobInterface
1313
/**
1414
* @inheritDoc
1515
*/
16-
public function execute(JobExecution $jobExecution): void
16+
final public function execute(JobExecution $jobExecution): void
1717
{
1818
if (!$jobExecution->getStatus()->isExecutable()) {
1919
$jobExecution->getLogger()->error('Job is not executable', ['job' => $jobExecution->getJobName()]);

src/batch/src/Job/Item/ItemJob.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ public function __construct(
6868
/**
6969
* @inheritDoc
7070
*/
71-
protected function doExecute(JobExecution $jobExecution): void
71+
final protected function doExecute(JobExecution $jobExecution): void
7272
{
7373
$rootExecution = $jobExecution->getRootExecution();
7474
$summary = $jobExecution->getSummary();

src/batch/src/Job/JobWithChildJobs.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
use Yokai\Batch\Registry\JobRegistry;
1010
use Yokai\Batch\Storage\JobExecutionStorageInterface;
1111

12-
final class JobWithChildJobs extends AbstractJob
12+
class JobWithChildJobs extends AbstractJob
1313
{
1414
/**
1515
* @var JobExecutionStorageInterface
@@ -44,7 +44,7 @@ public function __construct(
4444
/**
4545
* @inheritDoc
4646
*/
47-
protected function doExecute(JobExecution $jobExecution): void
47+
final protected function doExecute(JobExecution $jobExecution): void
4848
{
4949
$logger = $jobExecution->getLogger();
5050
foreach ($this->childJobs as $jobName) {

0 commit comments

Comments
 (0)