Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about aspect of verbs (Russian) #154

Open
PIPPOHSIOS opened this issue Oct 18, 2024 · 4 comments
Open

Add information about aspect of verbs (Russian) #154

PIPPOHSIOS opened this issue Oct 18, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@PIPPOHSIOS
Copy link

It could be really helpful to have the aspect of a verb (perfective or imperfective) and its respective counterpart in the definition. I'm using the Russian dictionary, but I'm sure the same applies for all the Slavic languages too.
image

@PIPPOHSIOS
Copy link
Author

While making the monolingual transition, I noticed that every term in the Russian monolingual dictionary does not have any tag at all. I've tried to fix it myself, and although I've had no luck, I noticed that each tag is just skipped, as the skippedTermTags.json file shows when creating the Yomitan dictionary.

@StefanVukovic99
Copy link
Collaborator

Added since #180

Image

@PIPPOHSIOS
Copy link
Author

I was talking about the ru-ru dictionary edition, I'm pretty sure every entry has no tag at all.
Image

@PIPPOHSIOS
Copy link
Author

I finally found a solution! I just copied both tag_bank_term.json and tag_bank_ipa.json from the folder data/language/target-language-tags/en/ to data/language/target-language-tags/ru/.

After compiling the dictionary, most of the tags appeared, but in particular the 'perfective' tag did not appear. Looking through the data in the Russian raw json file, I noticed that it doesn't show the 'perfective' tag, but instead there is a 'perfect' tag to denote a perfective verb. To work around the problem, I simply added the missing tag to tag_bank_term.json so that the script would not automatically ignore it.

I also noticed that other monolingual dictionaries have the same problem of not having a tag at all, though it should be fairly easy to fix by just copying the two files I mentioned earlier. I hope this helps you in some way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants