Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Visible Recommended Dictionary Headers #1489

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Fix Visible Recommended Dictionary Headers #1489

merged 1 commit into from
Oct 13, 2024

Conversation

MarvNC
Copy link
Member

@MarvNC MarvNC commented Oct 13, 2024 •
edited
Loading

Resolves #1485
msedge_Yomitan_Settings_and_2_more_pages_-Dev-_Microsof_2024-10-13_12-21-00

@MarvNC MarvNC requested a review from a team as a code owner October 13, 2024 19:20
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 13, 2024

CodSpeed Performance Report

Merging #1489 will not alter performance

Comparing MarvNC:fix-headers (71bc005) with master (f25775c)

Summary

✅ 3 untouched benchmarks

@MarvNC MarvNC added this pull request to the merge queue Oct 13, 2024
Merged via the queue into yomidevs:master with commit b51c094 Oct 13, 2024
11 checks passed
@MarvNC MarvNC deleted the fix-headers branch October 13, 2024 20:24
@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Casheeew Casheeew Casheeew approved these changes

Assignees
No one assigned
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kanji and Frequency dictionary headers still appearing when no dictionaries exist
3 participants
@MarvNC @Casheeew @Kuuuube