Use of defined? returns truthy value on nil

[keithrbennett]

For the methods whose names end with ?, do you maybe want to test for nil rather than test to see if the variable is defined? That is, you want the method to return false if it is defined as nil, right?

For example:

def stream?
  defined? @stream
end

Would this be better off as the following?:

def stream?
  !! @stream
end

I use !! because I find it helpful for methods ending with ? to return true or false, rather than truthy or falsy values. I feel it is more precise, and produces clearer and more concise output when logging/debugging using expressions like puts "stream? == #{foo.stream?}".

[abrom]

Good catch @keithrbennett

I don't believe this project is still being maintained. I've forked it and applied your suggestion:

https://github.com/abrom/henkei/releases/tag/v1.14.4