Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag for namespace exception #29

Closed
yonahd opened this issue Aug 21, 2023 · 4 comments · Fixed by #30
Closed

Add flag for namespace exception #29

yonahd opened this issue Aug 21, 2023 · 4 comments · Fixed by #30
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@yonahd
Copy link
Owner

yonahd commented Aug 21, 2023

Add a flag --exclude which will make kor run on all namespaces except the one included

@yonahd yonahd added enhancement New feature or request good first issue Good for newcomers labels Aug 21, 2023
@linrl3
Copy link
Contributor

linrl3 commented Aug 22, 2023

@yonahd Could I create a PR for this?

@yonahd
Copy link
Owner Author

yonahd commented Aug 22, 2023

@linrl3 be my guest

@yonahd yonahd linked a pull request Aug 27, 2023 that will close this issue
@doryer
Copy link

doryer commented Aug 29, 2023

@yonahd Btw, it will be great if it will accept a list + option to exclude resource when running all flag
like kor all --exclude-resource PVC --exclude-namespace foo,bar

@yonahd
Copy link
Owner Author

yonahd commented Aug 29, 2023

@doryer I think this is similar to this issue #2
We'll get to that soon hopefully

@yonahd yonahd added this to the v0.2.0 milestone Aug 30, 2023
@yonahd yonahd closed this as completed in #30 Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants