Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tree test for sync with js-sdk #611

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

MoonGyu1
Copy link
Contributor

@MoonGyu1 MoonGyu1 commented Aug 17, 2023

What this PR does / why we need it:

  • Add integration test cases in tree_test.go for sync with js-sdk's test cases

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

hackerwins and others added 2 commits August 17, 2023 15:19
Introduced new logical timestamp for identifying the position in
local/remote editing, and ensures commutative editing in concurrent
cases.

This logical timestamp consists of {parentID, leftSiblingID}. This
allows editing at the front of text nodes by using a reference to the
parent, as well as getting rid of the local offset used to access an
element node's children previously by using the leftSiblingID.

---------

Co-authored-by: MoonGyu1 <s201801402@hufs-gsuite.kr>
Co-authored-by: sejongk <sepaper@naver.com>
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #611 (1c544f7) into main (78f16d2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #611   +/-   ##
=======================================
  Coverage   48.66%   48.66%           
=======================================
  Files          69       69           
  Lines        9880     9880           
=======================================
  Hits         4808     4808           
  Misses       4571     4571           
  Partials      501      501           

@MoonGyu1 MoonGyu1 marked this pull request as ready for review August 21, 2023 02:54
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit 64cb38f into yorkie-team:main Aug 21, 2023
1 check passed
Wu22e pushed a commit to Wu22e/yorkie that referenced this pull request Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants